Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 303162 - Prevent unnecessary qooxdoo-flushs
Summary: Prevent unnecessary qooxdoo-flushs
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 1.3   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 1.3 M6   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-18 05:23 EST by Tim Buschtoens CLA
Modified: 2010-02-22 09:58 EST (History)
0 users

See Also:


Attachments
fix (15.06 KB, patch)
2010-02-18 05:58 EST, Tim Buschtoens CLA
ruediger.herrmann: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Buschtoens CLA 2010-02-18 05:23:53 EST
The qooxdoo flush is called a lot more often than really needed. There are mainly two reasons for this: The flush calling itself, and Image.js calling it for every instance of an loaded image. There are also two cases in rap-only widgets (Tree and Table) where the flush is called, but not as often.
Comment 1 Tim Buschtoens CLA 2010-02-18 05:58:56 EST
Created attachment 159411 [details]
fix

This patch reduces the number of flushs that occur during the startup of the controls-demo from 50 to 7. 

flushGlobalQueues() in no longer called in Image.js. Since the flush is already scheduled by Terminator, all this did was calling the flush once for every instance of Image instead of once for every image-file. Ideally we would not even have the qooxdoo Image anymore, using MultiCellWidget instead. (The instances of Image in the controls-demo were almost all invisible children of CTabItem, btw.)

_initAutoFlush in Widget.js has beed modified to check if the scheduled job will be executed durng the current flush or not. 

Needs to rebuild qx.js
Comment 2 Rüdiger Herrmann CLA 2010-02-22 09:58:12 EST
Applied patch to CVS HEAD