Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 302987 - [LTTng] Jni implementation should support multiple version of LTTng traces
Summary: [LTTng] Jni implementation should support multiple version of LTTng traces
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: LinuxTools (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: William Bourque CLA
QA Contact: Francois Chouinard CLA
URL:
Whiteboard:
Keywords:
Depends on: 310348
Blocks: 301633
  Show dependency tree
 
Reported: 2010-02-16 14:57 EST by William Bourque CLA
Modified: 2022-01-13 14:53 EST (History)
0 users

See Also:


Attachments
First implementation to support multiple trace version (133.99 KB, patch)
2010-02-16 15:36 EST, William Bourque CLA
william.bourque: iplog-
Details | Diff
Make the multiple version support is transparent (8.62 KB, patch)
2010-02-17 11:48 EST, William Bourque CLA
william.bourque: iplog-
Details | Diff
Activate the support for multiple trace version (27.66 KB, patch)
2010-03-12 12:38 EST, William Bourque CLA
william.bourque: iplog-
Details | Diff
Update the help files to reflect the change about multiple trace support (48.87 KB, patch)
2010-03-12 12:41 EST, William Bourque CLA
william.bourque: iplog-
Details | Diff
UPDATED : Activate the support for multiple trace version (previous patch included unrelated changes) (19.35 KB, patch)
2010-03-12 12:47 EST, William Bourque CLA
william.bourque: iplog-
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description William Bourque CLA 2010-02-16 14:57:23 EST
The current eclipse LTTng implementation only support "the latest" trace format. 
However, this mean that older trace format become imcompatible as soon as a new trace format is released.

To fix this, the JNI implementation should be able to differenciate the trace format and to load the correct one.
Comment 1 William Bourque CLA 2010-02-16 15:36:01 EST
Created attachment 159238 [details]
First implementation to support multiple trace version


This is the first imlementation to support multiple version of Lttng traces. 

The code kindly abuse of the java abstract classes to avoid code duplication so it should be easy to support multiple traces with almost no change to the code but by allowing changes to be made if needed for a certain version. 

Currently, this code will not do much more than what we do right now (i.e. will not support any but the latest trace version) because of some missing call and functions in the C library. 

Note : For the patched code to work, the new package "org.eclipse.linuxtools.lttng.jni" will need to be checkouted in the workspace.
Comment 2 William Bourque CLA 2010-02-17 11:48:21 EST
Created attachment 159337 [details]
Make the multiple version support is transparent


Add missing part to make the new "multiple version of trace" changes transparent. 

In other word, the architecture is ready but will not do anything for now, as the C library need to be modified prior to it. This patch make sure the JNI keep working transparently for the users; it should be removed as soon the C library is done.
Comment 3 William Bourque CLA 2010-03-12 12:38:14 EST
Created attachment 161905 [details]
Activate the support for multiple trace version

Finally activate the support for the multiple trace versions. 

The user will need to recompile the latest C library, details will be updated in the Help files as well.
Comment 4 William Bourque CLA 2010-03-12 12:41:39 EST
Created attachment 161906 [details]
Update the help files to reflect the change about multiple trace support


Update the help files, so the user know he needs to compile the latest C library. Also add some "bug" informations in the help so the user canunderstand why fails if he does not have the correct version installed.
Comment 5 William Bourque CLA 2010-03-12 12:47:52 EST
Created attachment 161907 [details]
UPDATED : Activate the support for multiple trace version (previous patch included unrelated changes)
Comment 6 William Bourque CLA 2010-03-17 15:07:09 EDT
Fixed and committed. 
Drawback : user now MUST use LTTv library version from http://git.dorsal.polymtl.ca/?p=liblttngtrace.git;a=summary as the changes are not mainline yet. 
Also, a version of LTTv must be compiled for each trace version that need to be supported.
Comment 7 Francois Chouinard CLA 2010-07-08 10:34:39 EDT
Released in a previous delivery.