Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 302747 - provide support to get the windows system image for search and cancel
Summary: provide support to get the windows system image for search and cancel
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows 7
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Shawn Minto CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 293230
  Show dependency tree
 
Reported: 2010-02-12 13:26 EST by Shawn Minto CLA
Modified: 2010-03-09 20:07 EST (History)
6 users (show)

See Also:


Attachments
patch (1.88 KB, patch)
2010-02-12 13:31 EST, Shawn Minto CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shawn Minto CLA 2010-02-12 13:26:10 EST
The images for the windows explorer search and cancel icons in their find box are in explorerframe.dll, which we could load so that the ICON_SEARCH and ICON_CANCEL icons can be use to provide a native look and feel on Windows 7.  This will allow for better emulation of a search widget as Windows does not provide a native widget (see bug 293230).
Comment 1 Shawn Minto CLA 2010-02-12 13:31:08 EST
Created attachment 159012 [details]
patch

Here is a patch that loads the explorerframe.dll and gets the bitmap for the search and cancel icons based on their resource index using OS.LoadImage.  

This dll was added in Windows Vista, but only the Windows 7 version contains these resources.  I tested against XP, Vista and 7 to ensure that there are no failures and that the icon or null was properly returned.
Comment 2 Felipe Heidrich CLA 2010-02-12 14:50:11 EST
this doesn't sound like a good idea...
I would think these images are protected by copyright, we would need to get legal to check on that.
Comment 3 Shawn Minto CLA 2010-02-12 17:18:10 EST
Thanks for pointing that out Filipe, I didn't realize that using the icon could be a problem.  I knew that packing it directly could be.  Is there someone that we can ask about the legal issues around this to see if we can use them or not?
Comment 4 Felipe Heidrich CLA 2010-02-17 16:15:48 EST
(In reply to comment #3)
>  Is there someone that we can ask about the legal 
> issues around this to see if we can use them or not?

Not sure, try enter a bug https://bugs.eclipse.org/bugs/enter_bug.cgi?product=Community
for component choose IPZilla
Comment 5 Shawn Minto CLA 2010-02-17 17:27:42 EST
Felipe, this seems like it is bugs for the IPZilla system and not the correct place to post a legal question.
Comment 6 Felipe Heidrich CLA 2010-02-18 09:42:56 EST
(In reply to comment #5)
> Felipe, this seems like it is bugs for the IPZilla system and not the correct
> place to post a legal question.

I think IPZilla is the right place for that. The right link is this:
https://dev.eclipse.org/ipzilla/index.cgi
Comment 7 Shawn Minto CLA 2010-02-18 15:51:55 EST
I have created a CQ for this.
Comment 8 Felipe Heidrich CLA 2010-02-26 15:22:16 EST
I'm closing this as wont fix.
Unfortunately the patch uses interal resource IDs which can change in future releases of platform.
Comment 9 Mik Kersten CLA 2010-03-09 20:01:28 EST
Ugh, too bad, I was hoping that we would get the nice looking native icon. On the plus side that icon did not follow the Eclipse icon style.  So maybe the goal now should be to make sure that we have a nice looking search/find icon.

Susan: Is there any IBM effort to provide a nice looking search/find icon that could be contributed to Eclipse?
Comment 10 Susan McCourt CLA 2010-03-09 20:07:19 EST
We were just talking about search visuals for e4 today, and figuring we would just use whatever native search look the platform gives us today rather than design a distinctive visual.

So we don't currently have plans to design a search icon.  I would imagine that we could open an icon request for this when we're ready to emulate the icon in the platform.