Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 302135 - [Theming] fix userForeground for disabled widgets
Summary: [Theming] fix userForeground for disabled widgets
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 1.3   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.3 M6   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 301010
  Show dependency tree
 
Reported: 2010-02-08 08:47 EST by Tim Buschtoens CLA
Modified: 2010-02-10 15:15 EST (History)
1 user (show)

See Also:

Attachments
fix (9.10 KB, text/plain)
2010-02-10 12:34 EST, Tim Buschtoens CLA 		ruediger.herrmann: iplog+
Details
Fix - passing all tests (2.00 KB, patch)
2010-02-10 14:41 EST, Rüdiger Herrmann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Buschtoens CLA 2010-02-08 08:47:28 EST 
The aspired behaviour is that disabled widgets ignore the userForeground and use the color given by the themeing. If the widget is re-enabled, the userForegound should be restored.

In case of the following widgets, the foreground overwrites the theming even if the widget is disabled: Button, Combo, CTabFolder, Text, Tree (partially)

The following widgets do not restore the foreground color: Toolbar.
Comment 1 Tim Buschtoens CLA 2010-02-08 08:54:20 EST 
This can be fixed in Control.java "getUserForeground" by returning null if the widget is disabled.

Currently userBACKground overwrites the themeing of disabled widget in all cases. It is not clear to me what the most usefull behaviour would be for background.
Comment 2 Tim Buschtoens CLA 2010-02-10 12:34:29 EST 
Created attachment 158749 [details]
fix
Comment 3 Rüdiger Herrmann CLA 2010-02-10 14:41:33 EST 
Created attachment 158764 [details]
Fix - passing all tests
Comment 4 Rüdiger Herrmann CLA 2010-02-10 14:43:03 EST 
Applied patch to CVS HEAD