Community
Participate
Working Groups
The org.eclipse.gmf.runtime.draw2d.ui.render.awt bundle has local preference settings that make extending @noextends classes an error yet GraphicsToGraphics2DAdaptor does exactly that. So extracting this from CVS results in a project with errors. It seems that a filter is needed. I'll attach a patch for that.
Created attachment 158179 [details] API filter to ignore the error
Hmm, I wonder why the API tools in my development environment did not catch this.
I looked at this again and I am still not seeing this API Tools error. I cannot remember if I fixed anything or not. I pointed my baseline to both 3.5.2RC3 and 3.4.2. I did apply an API filter as a result of the issue in Bug 292918 , but not to this particular bundle. I am getting uncomfortable and given we have no need to cheat anything, I am going to remove the filters and make the runtime 1.4.0 for helios (As I said in Bug 292918 ). Marking this one resolved fixed for now.
Te problem happens when hosted in 3.6M5. It didn't happen earlier in 3.6 so I think it's probably a bug fix in 3.6 itself to more strictly/properly check. Did you try to reproduce it that way?
Created attachment 162439 [details] Screen capture of problem It's really a problem. It's still there in M6. I must assume that the checking is more strict than in previous releases.
Ed, can you tell me what your baseline is in the API Tools preferences? Is this Galileo SR2? I have SR2 so I do not understand where you are getting this from. Windows + Preferences -> Plug-in Development + API Baselines If you select edit, can you tell me the version of org.eclipse.gmf.runtime.draw2d.ui.render.awt is in your baseline?
I have no baselines. That dialog is empty. I don't think this is a problem relative to some baseline though. It's a problem of extending a class that says it must not be implemented. Of course I don't know much about this but it does strike me that when one plugin has class that is marked @noextends and another class in another plugin extends it that this is a violation of a constraint and an override of that constraint is needed...
Oh, and I noticed you're asking about SR2 but I've already mentioned that this problem happens in M6. It was not a problem until M5 nor would I expect it was a problem for SR2.
I played some more and still cannot get this error. If I apply your patch I get the new warning: The API problem filter for: 'GraphicsToGraphics2DAdaptor illegally extends Graphics' is no longer used You need to have a baseline set in the API Tools preference page. Without a baseline, I get zero API tools errors but one warning for every project in GMF: An API baseline has not been set for the current workspace. Agreed that GraphicsToGraphics2DAdaptor illegally extends Graphics, although GraphicsToGraphics2DAdaptor is not API in GMF, so I do not think API tools reports this as an error anymore. Maybe it did with an older Eclipse version? Alex, can you check this out tomorrow when you do the API tools test for Bug 279728 ? Do you see this API Tooling error?
Anthony, I do get this error. I corrected the Draw2D plugin dependency version from 3.5.1 to 3.6 and still get the error. (I committed the upgrade of the plugin version - I should have done this in the first place anyway) The error is auto-corrected for me by adding an API filter for this error.
(In reply to comment #10) > Anthony, I do get this error. I corrected the Draw2D plugin dependency version > from 3.5.1 to 3.6 and still get the error. (I committed the upgrade of the > plugin version - I should have done this in the first place anyway) > > The error is auto-corrected for me by adding an API filter for this error. I installed a new eclipse on a second windows machine and I still do not see the error. In any case, Since we have two users who see the error, makes most sense to commit Ed's filter. Committed to HEAD
[target cleanup] 2.3 M7 was the original target milestone for this bug
[GMF Restructure] Bug 319140 : product GMF and component Runtime was the original product and component for this bug
