Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 301595 - [breakpoints view] Breakpoints disappear when hiding view in DSF debug session
Summary: [breakpoints view] Breakpoints disappear when hiding view in DSF debug session
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.6   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.6 M6   Edit
Assignee: Pawel Piech CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-02 15:36 EST by Marc Khouzam CLA
Modified: 2010-02-03 22:48 EST (History)
2 users (show)

See Also:
pawel.1.piech: review? (darin.eclipse)

Attachments
Fix for the platform side of the bug. (2.63 KB, patch)
2010-02-03 12:44 EST, Pawel Piech CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Khouzam CLA 2010-02-02 15:36:15 EST 
I just started using 3.6M5 and I'm running CDT HEAD.
This does not happen with M4 (although in some cases the breakpoints did disappear, but I couldn't reproduce it easily with M4)

To reproduce easily with M5:

1- Have a C++ project
2- create breakpoints -> they will be shown in the debug view
3- launch a DSF-GDB session
4- hide the breakpoints view
5- show the breakpoints view -> breakpoints are no longer shown.

To show the breakpoints again, I have to select the top launch element.

Please let me know if you need anything more.
Comment 1 Darin Wright CLA 2010-02-03 11:29:57 EST 
Pawel, is this problem specific to CDT? I don't see the issue with Java breakpoints. Could it be caused by overriding the viewer input?
Comment 2 Pawel Piech CLA 2010-02-03 12:44:56 EST 
Created attachment 158071 [details]
Fix for the platform side of the bug.

I looked into this last night but I ran out of time to commit the fixes.  There are two parts to this bug DSF and Platform.  

On the DSF side, the view input element returns an IViewerInputProvider, but the the provider never completes the request.  Since DSF-GDB doesn't have a real implementation for the IViewerInputProvider, it should at least return an error for the update.

On the platform side (a much less severe problem), the Breakpoints and the Expressions view don't examine the status in the completed update.  If the update returns an error, the view should use the default input.  

This patch addresses the platform side of the problem, I'll file a separate bug for DSF.
Comment 3 Marc Khouzam CLA 2010-02-03 16:03:22 EST 
I updated both plaftorm and DSF to get the patches of both this bug and bug 301726 and things now work properly.

Thanks!
Comment 4 Pawel Piech CLA 2010-02-03 22:48:08 EST 
I committed the fix this morning but I forgot to mark bug .... I also filed bug 301726 for the DSF side of the problem.

Darin please review.