Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 301428 - failing server-test xml-mergeinherited corrupts server-test ddl-generation
Summary: failing server-test xml-mergeinherited corrupts server-test ddl-generation
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Eclipselink (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows Vista
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: Nobody - feel free to take it CLA
QA Contact:
URL:
Whiteboard: test submitted_patch
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-01 11:08 EST by Adrian Goerler CLA
Modified: 2022-06-09 10:23 EDT (History)
2 users (show)

See Also:

Attachments
proposed patch (3.03 KB, patch)
2010-02-01 11:16 EST, Adrian Goerler CLA 		no flags Details | Diff
Additional patch (719 bytes, patch)
2010-03-04 07:34 EST, Sabine Heider CLA 		adrian.goerler: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Goerler CLA 2010-02-01 11:08:59 EST 
The server test "xml-mergeinherited" shares the test model with the test "ddl-generartion". It temporarily remanes the resource folder "resource/eclipselink-ddl-generation-model/server" to "resource/eclipselink-ddl-generation-model/server_ddl". After test execution, it renames teh folder again. But if the execution of "xml-mergeinherited" fails, the folder is left renamed causing the test "ddl-generation" to fail.
Comment 1 Adrian Goerler CLA 2010-02-01 11:16:56 EST 
Created attachment 157795 [details]
proposed patch

- Create a dedicated ant task "cleanup_merge_inherited_ddl", which does the cleanup after "server-test-xml-mergeinherited".
- Add a dependency from "server-test-ddlgeneration" on "cleanup_merge_inherited_ddl".
Comment 2 Adrian Goerler CLA 2010-02-02 02:31:12 EST 
reviewed by Kevin
checked in at rev # 6467
Comment 3 Adrian Goerler CLA 2010-02-02 02:31:54 EST 
see above
Comment 4 Sabine Heider CLA 2010-03-04 07:34:25 EST 
Created attachment 160929 [details]
Additional patch

The server test "xml-mergeinherited" should also execute the cleanup target, otherwise it corrupts the tests when executed again after a previous failure.
Patch attached.
Comment 5 Adrian Goerler CLA 2010-03-04 07:36:31 EST 
should be patches as proposed by Sabine
Comment 6 Adrian Goerler CLA 2010-06-07 07:56:39 EDT 
rescheduled to "future" as 2.1 is closed now
Comment 7 Adrian Goerler CLA 2011-06-07 10:52:40 EDT 
Comment on attachment 160929 [details]
Additional patch

Reviewed by Adrian
Tested on JBoss/MySQL
Checked in at 9526
Comment 8 Adrian Goerler CLA 2011-06-07 10:54:34 EDT 
patch checked in
Comment 9 Eclipse Webmaster CLA 2022-06-09 10:23:53 EDT 
The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink