Description Balazs Brinkus 2010-01-28 09:18:01 EST

Build Identifier: 

Hello,

the problem is that if you dispose a TableColumn then column won't be removed from the Table's _columnArea. 
So the table's columns count will be the same before the remove.

The test application (I attached the full test application):
	var table = new org.eclipse.swt.widgets.Table("w3", "");

	this.debug("Add columns");
	var column1 = new org.eclipse.swt.widgets.TableColumn(table);
	column1.setLabel("Column1")
	var column2 = new org.eclipse.swt.widgets.TableColumn(table);
	column2.setLabel("Column2")
	var column3 = new org.eclipse.swt.widgets.TableColumn(table);
	column3.setLabel("Column2")
	this.debug("Columns count: "+table.getColumnCount());			

	this.debug("Remove columns");
	column2.dispose();
	column3.dispose();
	column1.dispose();
	this.debug("Columns count: "+table.getColumnCount());

The FireBug output:

	DEBUG: applications.TableApplication[20]: Add columns
	DEBUG: applications.TableApplication[20]: Columns count: 3
	DEBUG: applications.TableApplication[20]: Remove columns
	DEBUG: applications.TableApplication[20]: Columns count: 3

So you need to extend the _removeColumn method:

	// org.eclipse.swt.widgets.Table line 1170
	_removeColumn : function( column ) {
		this._unhookColumnMove( column );		
		column.removeEventListener( "changeWidth", this._onColumnChangeSize, this );
>		this._columnArea.remove(column);
		this._updateScrollWidth();
		this._updateRows();
	},
	
I checked the Table's latest version (1.79) and it also contains this bug.
	

Regards,
Balazs Brinkus


Reproducible: Always