Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 300891 - Replace use of ssh exec with sftp in other classes.
Summary: Replace use of ssh exec with sftp in other classes.
Status: RESOLVED FIXED
Alias: None
Product: PTP
Classification: Tools
Component: Remote Tools (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.0.1   Edit
Assignee: Dieter Krachtus CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-26 13:41 EST by Dieter Krachtus CLA
Modified: 2010-05-31 19:29 EDT (History)
3 users (show)

See Also:

Attachments
Patch classes to use SFTP throughout instead of ssh exec (18.11 KB, patch)
2010-01-26 13:44 EST, Dieter Krachtus CLA 		g.watson: iplog+
Details | Diff
Same patch as before but without removing Execution interface (6.27 KB, patch)
2010-01-26 18:55 EST, Roland Schulz CLA 		g.watson: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dieter Krachtus CLA 2010-01-26 13:41:22 EST 
Build Identifier: HEAD

This is a independent followup to the fix: https://bugs.eclipse.org/bugs/show_bug.cgi?id=300889

Changes affect mainly CopyTools and related interfaces. As bug #300889 outlines this approach is much faster and more robust.

Reproducible: Always
Comment 1 Dieter Krachtus CLA 2010-01-26 13:44:58 EST 
Created attachment 157321 [details]
Patch classes to use SFTP throughout instead of ssh exec
Comment 2 Greg Watson CLA 2010-01-26 14:30:22 EST 
Can you please add an "I declare..." statement that you contribute under EPL and have the right doing so -- see http://www.eclipse.org/dsdp/tm/development/committer_howto.php#external_contrib

Thanks!
Comment 3 Dieter Krachtus CLA 2010-01-26 14:52:10 EST 
I, Dieter Krachtus, declare that I developed attached code from scratch, without referencing any 3rd party materials except material licensed under the EPL. I certify that I am the copyright owner and authorize this contribution.
Comment 4 Greg Watson CLA 2010-01-26 18:25:49 EST 
Unfortunately this patch appears to change some public interfaces which is not possible for a bug release (e.g. 3.0.1). I can apply this patch as is to HEAD, but would it possible to do another version of the patch that leaves the interfaces untouched and just changes the implementation. I would then be able to apply that version to the 3.0 branch.
Comment 5 Roland Schulz CLA 2010-01-26 18:55:36 EST 
Created attachment 157357 [details]
Same patch as before but without removing Execution interface

Yes it is not necessary to change the public interface. We just removed the execution interfaces because they are not needed anymore. I attached the patch with the change to sftp without removing the (unneeded) execution interface.
Since it these interfaces are not needed anymore I'd suggest to apply the original patch to HEAD.
Comment 6 Greg Watson CLA 2010-01-26 20:12:13 EST 
Commited first patch to HEAD.
Comment 7 Greg Watson CLA 2010-01-27 09:38:38 EST 
Committed second patch to 3.0.
Comment 8 Greg Watson CLA 2010-01-27 09:42:58 EST 
Applied.