Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 300844 - [Commands] [Contributions] 'Open Resource' dialog menu has extra separator
Summary: [Commands] [Contributions] 'Open Resource' dialog menu has extra separator
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 minor with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-26 10:48 EST by Remy Suen CLA
Modified: 2020-05-05 05:37 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2010-01-26 10:48:36 EST
I20100125-1800

1. Ctrl+Shift+R
2. Click the drop-down arrow in the top right.
3. A trailing separator menu item can be seen at the bottom.
Comment 1 Markus Keller CLA 2010-03-26 10:02:35 EDT
The problem is the CompoundContributionItem that is now added by the WorkingSetFilterActionGroup (since bug 252497).

MenuManager#update(boolean, boolean) needs to take dynamic contributions like CompoundContributionItem into account (in fact all IContributionItems whose #fill(Menu, int) adds not exactly 1 item). The simple loop at the top that deals with separators is not enough.

Note that a CompoundContributionItem can also contribute separators at the beginning, at the end, or even multiple consecutive separators (though the last case could also be handled in CompoundContributionItem).
Comment 2 Eclipse Genie CLA 2020-05-05 05:37:36 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.