Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 300827 - [xpand.ui] Provide user-configurable syntax coloring / markup
Summary: [xpand.ui] Provide user-configurable syntax coloring / markup
Status: CLOSED FIXED
Alias: None
Product: M2T
Classification: Modeling
Component: Xpand (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: M5   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-26 09:58 EST by Erhard Weinell CLA
Modified: 2013-02-21 08:10 EST (History)
1 user (show)

See Also:
sven.efftinge: helios+


Attachments
Adds user-configurable syntax coloring (31.48 KB, patch)
2010-01-26 10:09 EST, Erhard Weinell CLA
no flags Details | Diff
Adds user-configurable syntax coloring (42.70 KB, patch)
2010-01-27 09:25 EST, Erhard Weinell CLA
sven.efftinge: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Erhard Weinell CLA 2010-01-26 09:58:43 EST
As I am personally not too convinced of the standard Xpand syntax highlighting, I'd rather prefer user-configurable options to set colors and font styles. Currently, this is hard-coded into the editor.
Comment 1 Erhard Weinell CLA 2010-01-26 10:09:37 EST
Created attachment 157260 [details]
Adds user-configurable syntax coloring

This is a proposed patch to add configurable syntax coloring. It still has some known issues, mainly:

* Open Xpand editors are not updated on preference change - they need to be closed and re-opened.
* Cannot use underline and (questionable) strikethrough text attribute
* Xtend editor does not honor the preferences yet

Consider it as initial proposal.

The code is similar to xtext.ui.core, although no additional dependencies are added.
Comment 2 Sven Efftinge CLA 2010-01-26 10:17:56 EST
Thanks, for the start.
If you (or someone else) fixes the outstanding issues, chances that this goes into the repository will increase significantly ;-)
Comment 3 Erhard Weinell CLA 2010-01-27 09:25:53 EST
Created attachment 157397 [details]
Adds user-configurable syntax coloring

Updated version, fixes the known issues (see above)
Comment 4 Erhard Weinell CLA 2010-01-27 09:27:48 EST
As the known issues are solved by now, I'd be happy to receive user-feedback.
Comment 5 Sven Efftinge CLA 2010-01-27 10:12:48 EST
Looks good.
I've changed the colors a bit, so that they fit better with the JDT look.
But I tried to stick with your intention.

Let's see how other users like the new coloring :-)

Patch applied.
Comment 6 Karsten Thoms CLA 2013-02-21 08:10:56 EST
Bug resolved before Xpand 1.2 release date => Closing