Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 300819 - MatchService.resolveAll fails to resolve proxies (and thus to detect fragment resources) within resources loaded with RevisionComparisonHandler
Summary: MatchService.resolveAll fails to resolve proxies (and thus to detect fragment...
Status: CLOSED FIXED
Alias: None
Product: EMFCompare
Classification: Modeling
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: Macintosh Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: EMF Compare CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 300813 300814 300815 300817 300818 (view as bug list)
Depends on: 303976
Blocks:
  Show dependency tree
 
Reported: 2010-01-26 09:26 EST by Alexander Nyßen CLA
Modified: 2013-04-24 07:30 EDT (History)
0 users

See Also:

Attachments
Patch to fix RevisionComparisonHandler so that it uses absolute platform:resource uris rather than relative ones (6.38 KB, patch)
2010-01-26 09:29 EST, Alexander Nyßen CLA 		no flags Details | Diff
Updated patch, now also includes fix for SubversiveTeamHandler (8.47 KB, patch)
2010-02-01 04:42 EST, Alexander Nyßen CLA 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Nyßen CLA 2010-01-26 09:26:44 EST 
Build Identifier: M20090917-0800

The relative file uris the RevisionComporisonHandler uses to load its resources lead to a problem within the MatchService.resolveAll method, where unresolvable proxies (due to relative proxy uris) cannot be resolved and thus fragment resources cannot be detected. This leads to a problem e.g. when comparing a fragment resource with its local history.

Reproducible: Always
Comment 1 Alexander Nyßen CLA 2010-01-26 09:29:53 EST 
Created attachment 157252 [details]
Patch to fix RevisionComparisonHandler so that it uses absolute platform:resource uris rather than relative ones

Refactored RevisionComparisonHandler so that its Resolver is used to normalize all relative uris into platform:resource uris. Ensured that when loading models via ModelUtils, the normalizer is also asked so that comparison can always be performed on the basis of platform:resource plugins.

Also fixed (by normalizing the uri before loading) that pathmap uris could not be resolved to corresponding platform:plugin uris.
Comment 2 Cedric Brun CLA 2010-01-26 09:32:29 EST 
*** Bug 300818 has been marked as a duplicate of this bug. ***
Comment 3 Cedric Brun CLA 2010-01-26 09:32:36 EST 
*** Bug 300817 has been marked as a duplicate of this bug. ***
Comment 4 Cedric Brun CLA 2010-01-26 09:32:43 EST 
*** Bug 300815 has been marked as a duplicate of this bug. ***
Comment 5 Cedric Brun CLA 2010-01-26 09:32:48 EST 
*** Bug 300814 has been marked as a duplicate of this bug. ***
Comment 6 Cedric Brun CLA 2010-01-26 09:32:54 EST 
*** Bug 300813 has been marked as a duplicate of this bug. ***
Comment 7 Alexander Nyßen CLA 2010-02-01 04:42:36 EST 
Created attachment 157750 [details]
Updated patch, now also includes fix for SubversiveTeamHandler
Comment 8 Alexander Nyßen CLA 2010-05-03 14:48:10 EDT 
Resolved as part of #301112.
Comment 9 Laurent Goubet CLA 2011-08-18 04:05:45 EDT 
Closing our "resolved" and "verified" bugs.