Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 300731 - subproject mode changed to plain file mode
Summary: subproject mode changed to plain file mode
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 critical with 2 votes (vote)
Target Milestone: ---   Edit
Assignee: Christian Halstrick CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 356664
Blocks: 306765 314853
  Show dependency tree
 
Reported: 2010-01-25 15:34 EST by Shawn Pearce CLA
Modified: 2011-09-18 16:25 EDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shawn Pearce CLA 2010-01-25 15:34:34 EST 
If a tree contains a subproject mode (160000), creating a commit in
EGit can convert this to be a plain text file mode (100644), which
results in Git assuming the target object is a blob in this project.

If the target object is actually a commit in this project, we get
weird failures from JGit trying to cast a RevBlob to a RevCommit,
and `git fsck --full` gets confused, claiming a blob was used in
a commit context.

This results in a corrupt repository, because the target isn't
valid anymore.
Comment 1 Lothar Werzinger CLA 2010-07-07 17:13:58 EDT 
Could this be related to Bug 307560 ?
Comment 2 Robin Rosenberg CLA 2011-09-07 16:28:59 EDT 
I think this is ok after 356664. 

Before this I could not commit a submodule change at all.
Comment 3 Robin Rosenberg CLA 2011-09-18 16:25:41 EDT 
No objections. Closing.