Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 300623 - Speed improvement of directory listing
Summary: Speed improvement of directory listing
Status: RESOLVED FIXED
Alias: None
Product: PTP
Classification: Tools
Component: Remote Tools (show other bugs)
Version: 3.0   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: 3.0.1   Edit
Assignee: Roland Schulz CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-24 18:31 EST by Roland Schulz CLA
Modified: 2010-05-31 19:30 EDT (History)
2 users (show)

See Also:


Attachments
Patch for the speed enhancement (3.65 KB, patch)
2010-01-24 18:32 EST, Roland Schulz CLA
g.watson: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Roland Schulz CLA 2010-01-24 18:31:07 EST
Build Identifier: CVS HEAD

This enhancement improves the speed of the directory listing using the RemoteTools connection.
Before this patch the directory listing was slow because a sftp-stat was performed for each file when listing a directory. It is possible to get the same information for all files in the directory with a single stat call. This call is actually already done previously to get the file names of all files and we simply reuse this information in our patch. This patch removes redundant communication which increases performance especially for directory listings that are containing many files.

Reproducible: Always

Steps to Reproduce:
1. Connect with Remotetools
2. Open a directory
Comment 1 Roland Schulz CLA 2010-01-24 18:32:13 EST
Created attachment 157066 [details]
Patch for the speed enhancement
Comment 2 Greg Watson CLA 2010-01-25 09:56:09 EST
This looks very useful, thanks! Applied to 3.0 and HEAD.
Comment 3 Greg Watson CLA 2010-01-26 14:00:21 EST
Committed.
Comment 4 Greg Watson CLA 2010-01-26 14:29:39 EST
Can you please add an "I declare..." statement that you contribute under EPL and have the right doing so -- see http://www.eclipse.org/dsdp/tm/development/committer_howto.php#external_contrib

Thanks!