Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 300518 - Find unused dependencies removes (indirectly?) required packages
Summary: Find unused dependencies removes (indirectly?) required packages
Status: CLOSED DUPLICATE of bug 181074
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-22 11:56 EST by Andrew Niefer CLA
Modified: 2010-04-05 17:00 EDT (History)
3 users (show)

See Also:

Attachments
map files of the p2 projects (12.45 KB, application/octet-stream)
2010-03-30 09:14 EDT, Pascal Rapicault CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Niefer CLA 2010-01-22 11:56:37 EST 
For example, I ran this on 'org.eclipse.equinox.p2.artifact.repository', the proposed list of unused dependencies was:
org.eclipse.equinox.app
org.eclipse.equinox.internal.provisional.p2.metadata
org.eclipse.equinox.p2.repository.spi
org.eclipse.osgi.framework.log
org.osgi.service.prefs

After removing them all, in order to fix resulting compilation errors, 2 packages needed to be added back:
org.osgi.service.prefs
org.eclipse.equinox.p2.repository.spi
Comment 1 Curtis Windatt CLA 2010-01-22 14:44:09 EST 
Dupe of bug 99031, bug 181074 of bug 238694?
Comment 2 Pascal Rapicault CLA 2010-03-30 09:10:31 EDT 
I have once again given an attempt at this functionality, and once again the story is pain and sorrow. This is very unfortunate because this bug makes the overall functionality useless for any serious development.

I do not claim that I would do better, but I think that we should not leave this functionality enabled by default since we know that it is broken in some fundamental ways and can only cause frustration.
Comment 3 Pascal Rapicault CLA 2010-03-30 09:14:25 EDT 
Created attachment 163405 [details]
map files of the p2 projects

Find attached a map file of all the p2 projects in a state where running a "find unused dependency" will result in a compile errors.
Comment 4 John Arthorne CLA 2010-03-30 09:16:18 EDT 
I think in our case this is a duplicate of bug 181074. Whenever I have tried this on p2 bundles, it always produces the wrong result due to our extensive use of import-package. We should likely just disable this functionality for any bundle that has import-package if it can't be fixed.
Comment 5 John Arthorne CLA 2010-04-05 17:00:52 EDT 
See also bug 208844 for the same problem in the manifest cleanup wizard.

*** This bug has been marked as a duplicate of bug 181074 ***