Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 300462 - [modeling] [masterdetails] Remove button and remove toolbar action should be bound to the EmfActionBarContributor's Delete action
Summary: [modeling] [masterdetails] Remove button and remove toolbar action should be ...
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: Incubators (show other bugs)
Version: 3.6   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Benjamin Cabé CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-22 03:38 EST by Jacques LESCOT CLA
Modified: 2010-01-22 11:43 EST (History)
1 user (show)

See Also:

Attachments
Use the DELETE action of the EmfActionBarContributor when available (8.18 KB, patch)
2010-01-22 03:41 EST, Jacques LESCOT CLA 		no flags Details | Diff
Reuse the Action already defined for the remove toolbar action to the Remove button (1.62 KB, patch)
2010-01-22 04:03 EST, Jacques LESCOT CLA 		no flags Details | Diff
Refactor the DELETION mechanism (12.24 KB, patch)
2010-01-22 08:16 EST, Jacques LESCOT CLA 		contact: iplog+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jacques LESCOT CLA 2010-01-22 03:38:30 EST 
When an EmfActionBarContributor is associated with the editor, and that a DELETE action is available, use it preferably.
Comment 1 Jacques LESCOT CLA 2010-01-22 03:41:06 EST 
Created attachment 156902 [details]
Use the DELETE action of the EmfActionBarContributor when available
Comment 2 Jacques LESCOT CLA 2010-01-22 04:03:59 EST 
Created attachment 156904 [details]
Reuse the Action already defined for the remove toolbar action to the Remove button
Comment 3 Jacques LESCOT CLA 2010-01-22 08:16:20 EST 
Created attachment 156930 [details]
Refactor the DELETION mechanism

I have updated the Deletion mechanism so that we always delegate the task to the DELETE action registered through the EmfActionBarContributor associated with the editor.
The confirmation dialog is no longer shown. Instead, clients that wish to prompt such dialog before executing the Delete action should modify the directly the Delete action at the EmfActionBarContributor level.
Comment 4 Benjamin Cabé CLA 2010-01-22 11:42:37 EST 
Available in HEAD > 20100122.
Thank you Jacques.