Comment 1 Yang Meyer 2010-01-21 10:59:03 EST

Created attachment 156807 [details]
Fixes bug and adds explanatory javadoc comments

Reason for test failure:

Character.isUppercase('/') is false 
=> No 'Shift' key events sent 
=> German QWERTZ keyboard means that / = Shift+7
=> '7' is printed on shell

Comment 2 Christian Campo 2010-01-22 09:15:28 EST

fixed in CVS Head

Comment 3 Elias Volanakis 2010-01-22 16:20:32 EST

Thanks!

Comment 4 Elias Volanakis 2010-01-22 17:10:42 EST

The tests now break on my machine.

The problem is that I've a US locale / keyboard (/ is on the lower letter on the ? key) and you have a german one (/ is Shift-7)   :-)

I'll add some code to workaround this.

Comment 5 Yang Meyer 2010-01-25 02:03:04 EST

(In reply to comment #4)
> The problem is that I've a US locale / keyboard (/ is on the lower letter on
> the ? key) and you have a german one (/ is Shift-7)   :-)

This might actually become quite an annoying issue: '/' requires a Shift on German QWERTZ but not on Czech QWERTZ; most QWERTY keyboards don't need a Shift but Canadian French QWERTY does; Shift is needed for Hebrew but not for Greek keyboard layout; ...
http://en.wikipedia.org/wiki/Keyboard_layout

I wonder why Java does not respect the logical keyboard layout that I set using the OS's input manager :-/

Comment 6 Elias Volanakis 2010-01-25 02:45:09 EST

I think for our purposes it is good enough if the test pass => german & us support be enough.

I've fixed this in head since Friday.