Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 299858 - Project Explorer is not notified when FolderDescription is created for an existing folder
Summary: Project Explorer is not notified when FolderDescription is created for an exi...
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-build (show other bugs)
Version: 6.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 6.0.2   Edit
Assignee: Andrew Gvozdev CLA
QA Contact: Elena Laskavaia CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 299857
  Show dependency tree
 
Reported: 2010-01-16 21:38 EST by Andrew Gvozdev CLA
Modified: 2010-01-18 00:29 EST (History)
0 users

See Also:

Attachments
patch (3.29 KB, patch)
2010-01-17 16:05 EST, Andrew Gvozdev CLA 		angvoz.dev: iplog-
Details | Diff
patch 2 (6.48 KB, patch)
2010-01-17 21:53 EST, Andrew Gvozdev CLA 		angvoz.dev: iplog-
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Gvozdev CLA 2010-01-16 21:38:16 EST 
1. Create empty managed project.
2. Create a regular (non-source) folder in the project.
3. Go to the folder's properties and select C/C++ Build. 
4. Do not make any changes but press OK to save.
5. In Project Explorer there is no any overlay shown on the folder. Press F5 to refresh the folder. The overlay appears.

There are 2 problems with that. One is that new FolderDescription is created and stored in the model needlessly. Another one is that the listeners are not notified about that. This bug is to fix the second problem. I'll take a look at first with bug 298590.
Comment 1 Andrew Gvozdev CLA 2010-01-17 16:05:44 EST 
Created attachment 156334 [details]
patch
Comment 2 Andrew Gvozdev CLA 2010-01-17 16:07:37 EST 
Committed on HEAD (7.0)
Comment 3 Andrew Gvozdev CLA 2010-01-17 21:53:26 EST 
Created attachment 156346 [details]
patch 2

An addition to patch 1 with slight and hopefully more accurate rewrite of the method.
Committed on HEAD (7.0) as well.
Comment 4 Andrew Gvozdev CLA 2010-01-18 00:29:30 EST 
Committed also on 6.0.2 for the benefit of bug 247021