Description Pavel Samolisov 2010-01-16 13:50:46 EST

I'm working on OSCAR/ICQ provider for Eclipse Communication Framework
and implemented Remote Service API via OSCAR/ICQ.

I want suggest small changes to AbstractRemoteServicesTest:

1. add assertTrue(done); after waiting to method testServiceListener. If
do not check 'done' - test can be passed if even RemoteServiceListener
was not be invoked.

2. add protected method customizeProperties and invoked it for
customizing register services properties in other bundles. For example
in the org.eclipse.ecf.tests.provider.oscar I implemented this method:

protected Dictionary customizeProperties(Dictionary props) {
	Dictionary result = new Hashtable();
	// ...
	result.put(Constants.SERVICE_REGISTRATION_TARGETS,
getClient(1).getConnectedID());
	return result;
}

If we do not put Constants.SERVICE_REGISTRATION_TARGETS to properties,
test testServiceListener will not be passed because
adapters[0].registerRemoteService will not send message to
containers[1]. ICQ do not support predefined groups and do not send
broadcast messages.