Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 299544 - Links in dropins directory are never rescanned
Summary: Links in dropins directory are never rescanned
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.4.2   Edit
Hardware: All Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 3.4.2+   Edit
Assignee: DJ Houghton CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 269297
Blocks:
  Show dependency tree
 
Reported: 2010-01-13 14:17 EST by DJ Houghton CLA
Modified: 2010-04-07 06:12 EDT (History)
5 users (show)

See Also:


Attachments
Patch against r34x (17.81 KB, patch)
2010-01-19 15:15 EST, DJ Houghton CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description DJ Houghton CLA 2010-01-13 14:17:29 EST
+++ This bug was initially created as a clone of Bug #269297 +++

Build ID: M20090211-1700

Steps To Reproduce:
If I add a plugin directly into the "dropins" directory, it will be picked up automatically.  But if I have a .link file in the dropins directory, and I add a plugin to the directory that it points to, the new plugin is not loaded automatically.  Even touching the .link file doesn't fix this.  Only renaming the .link file works.

1. Add a "xyz.link" file to the dropins directory, with a line like "path=.../xyz", where ".../xyz" is an absolute path to some directory on your system.  Under "xyz" there should be an "eclipse/plugins" subdir.  Add any plugin to that dir.
2. Launch Eclipse.  The plugin you added is detected automatically.
3. Exit Eclipse.  Add a *second* plugin to the xyz/eclipse/plugins directory, and launch Eclipse again.

Actual result:
The first plugin is still loaded, but the second one is not.  Even if you do "touch xyz.link", it still isn't picked up.  But if you rename xyz.link to xyzz.link, then it IS picked up.

Expected result:
I would expect that links in the dropins directory would have the same "automatically rescan" characteristics that the dropins directory itself has.  (I am not expecting some sort of infinite recursion.  It's just that .link files provide a convenient way to keep your plugins organized, but the issue described here makes it harder for me to keep my dropins in a separate directory.)
Comment 1 DJ Houghton CLA 2010-01-13 14:21:09 EST
Cloned this bug to track a backport to Eclipse 3.4.2.

Code changes can be viewed by looking at edits to the reconciler.dropins bundle on March 27/28, 2009.
Comment 2 DJ Houghton CLA 2010-01-19 15:15:51 EST
Created attachment 156561 [details]
Patch against r34x
Comment 3 DJ Houghton CLA 2010-01-19 15:33:06 EST
Patch released to r34x maintenance stream.
Comment 4 Krzysztof Daniel CLA 2010-04-07 06:12:56 EDT
It looks like the links are rescanned if the .link is touched. I am not sure if this was the intention but it still acceptable for me.