This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 299493 - [Trim] Need a status line renderer / enhancements to trim model
Summary: [Trim] Need a status line renderer / enhancements to trim model
Status: RESOLVED WORKSFORME
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Lars Vogel CLA
QA Contact: Eric Moffatt CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 303778
  Show dependency tree
 
Reported: 2010-01-13 10:07 EST by Remy Suen CLA
Modified: 2015-02-03 09:56 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2010-01-13 10:07:27 EST
<rcjsuen> emoffatt: How is a developer supposed to get a status line via MWindowTrim?
<emoffatt> rcjsuen: why not use the getActionBars API ?
<rcjsuen> emoffatt: (3.x) action bars ultimately delegates to a JFace ApplicationWindow
<emoffatt> are we talking for a 3.x user or an e4 implementation ?
<rcjsuen> emoffatt: An e4 implementation.
<rcjsuen> We implement the compatibility layer using e4 APIs as much as possible, so I am interested in an e4 implementation.
<emoffatt> np, findById (as long as we give it an id (I think it already has one in 3.x
<emoffatt> We'll likely need to add a new model element 'TrimElement' or some such to provide a rendering hook
Comment 1 Lars Vogel CLA 2010-02-15 17:50:22 EST
Remy pointed me to this bug. I believe the e4 model should offer the possibility to add a status line to the application. This is in my opinion not only relevant for 3.X applications but also for pure e4 applications.
Comment 2 Eric Moffatt CLA 2010-02-16 10:25:38 EST
The question is whether we want an 'integrated' status line (a la StatusLineManager) or should we perhaps just allow folks to model whatever (allowable) structure they desire.

Currently eclipse has both; a specialized status line as well as other widgets that appear at the bottom (FVB, progress, HeapStatus...). It's somehow always seemed to me that we should have one or the other.
Comment 3 Lars Vogel CLA 2010-02-16 11:17:43 EST
In my experience the shared status line is not as useful as information you put there is always overwritten by other plugins. 

I think it would be useful to allow to model individual parts in a statusline area which can then be individually accessed. I hope I got your comment correct.
Comment 4 Eric Moffatt CLA 2010-02-16 13:04:08 EST
Sounds like you nailed it to me. If we need to add flexibility to handle multiple contributions then we could add the equivalent of 'visibleWhen' clauses to then model.
Comment 5 Lars Vogel CLA 2013-06-18 08:50:37 EDT
@Eric, is this bug still relevant?
Comment 6 Eric Moffatt CLA 2013-06-18 10:51:30 EDT
Lars....'yes', it's just a part of the overall effort to 'flesh out' e4 RCP.

Good Pickup.
Comment 7 Eric Moffatt CLA 2013-10-21 14:45:59 EDT
Lars, I'm leaving this one open but I think we might re-purpose it to allow a 'visibleWhen' clause on to almost any UI element (MToolBar, MTrimControl, MPart?).

What do you think ?
Comment 8 Lars Vogel CLA 2013-10-21 14:56:58 EDT
(In reply to Eric Moffatt from comment #7)
> Lars, I'm leaving this one open but I think we might re-purpose it to allow
> a 'visibleWhen' clause on to almost any UI element (MToolBar, MTrimControl,
> MPart?).
> 
> What do you think ?

+1
Comment 9 Lars Vogel CLA 2014-05-06 18:19:12 EDT
Currently e4 RCP application can define their custom status bar. I think this works well. Marking as WORKSFORME.