Description Meng Xin Zhu 2010-01-10 21:44:50 EST

Build Identifier: 3.6 M4

                protected IRepository basicGetRepository(URI location) {
                                                  ......................
                                                  IRepository repo = (IRepository)
info.repository.get();
                                                  //update our repository info because the
repository may have changed
                                                  if (repo != null)
                                                                   addRepository(repo, false, null);
                                                  return repo;
                                 }
                }

The comment tells me the repo may have changed, so update the repository
info. If so, why still returns the cached repo though the real repo
might have changed? Why reset the known suffix for that repo even if
it's necessary to update the repo info? My understand is that the suffix
escalates the hit rate of loading when there are multiple repo
factories. If the repo info records a suffix for the location, repo
manager would firstly use the factory that is bind to the suffix. It's
also a rare situation that the type of repo is changed. So it would be
higher hit rate to load the repo again if keeping the value of suffix.

Reproducible: Always