This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 299118 - [Preferences] Open mode not updated after importing preferences
Summary: [Preferences] Open mode not updated after importing preferences
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: 4.4 M6   Edit
Assignee: Dani Megert CLA
QA Contact: Oleg Besedin CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-08 07:07 EST by Dani Megert CLA
Modified: 2014-05-30 10:53 EDT (History)
1 user (show)

See Also:


Attachments
Fix (2.29 KB, patch)
2014-01-22 10:14 EST, Dani Megert CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2010-01-08 07:07:27 EST
R3.1 and all newer builds

The open strategy is not updated after importing preferences. The change can be seen on the preference page but it has not been applied/propagated to the views.

1. choose single click open mode in your workspace
2. export all preferences
3. start a new workspace
4. import all preferences from previous export
5. create a project and a file in the Navigator or Package Explorer
6. close the editor
7. single click on the file
==> does not open


Some static instance in the workbench that listens for preference changes would also have to update the OpenStrategy's open mode by calling org.eclipse.jface.util.OpenStrategy.setOpenMethod(int).
Comment 1 Oleg Besedin CLA 2010-01-08 10:52:02 EST
Note:
On the startup the call chain to set this option is:
	Workbench#init()
		Workbench#initializeSingleClickOption()
			OpenStrategy.setOpenMethod()

The preference page does
	WorkbenchPreferencePage#performOk
		OpenStrategy.setOpenMethod()
Comment 2 Dani Megert CLA 2014-01-22 10:14:42 EST
Created attachment 239226 [details]
Fix
Comment 4 Wojciech Sudol CLA 2014-05-30 10:53:18 EDT
Verified in I20140528-2000.