This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 298971 - Unchecking Cascade Delete Relationships preference checkbox ignored
Summary: Unchecking Cascade Delete Relationships preference checkbox ignored
Status: CLOSED INVALID
Alias: None
Product: Tigerstripe (Archived)
Classification: Technology
Component: Core (show other bugs)
Version: 0.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 0.5M0   Edit
Assignee: Richard Craddock CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-06 12:41 EST by Duncan Keysell CLA
Modified: 2011-11-23 10:48 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Duncan Keysell CLA 2010-01-06 12:41:18 EST
I unchecked the "Cacade Delete Relationships:" checkbox and pressed the Apply button followed by  the OK button.

In my model i had an assocation between an Entity and a Datatype. On deletion of the datatype from the explorer the association was also deleted, i.e. a cascade delete although cascade delete preference not checked.
Comment 1 Richard Craddock CLA 2010-01-21 10:21:11 EST
It may be because of this ...


// This may be turned off by the user through the General preference
// page
// if (!BasePlugin.getDefault().getPreferenceStore().getBoolean(
// GeneralPreferencePage.P_CASCADEDELETE_RELATIONSHIPS))
// return;


Its all commented out.
Comment 2 Richard Craddock CLA 2010-01-21 10:24:08 EST
The preference is defined in the ui plugin.....


which might explain how we got in this mess...

I presume someone commented out the code I highlighted, because it could not be 
refrerred to when we split ui and bse?
Comment 3 Eric Dillon CLA 2010-01-21 10:44:48 EST
Might even be me, hoping to come back to it, but it looks like it never happened.
Comment 4 Richard Craddock CLA 2010-01-21 11:00:44 EST
So the plan is to move the "General Tigerstripe" Preferences to the BasePlugin.

They will still be edited only thoughthe ui plugin, but should be accessible form the Base code
Comment 5 Richard Craddock CLA 2010-01-22 04:41:19 EST
Following a detailed investigation, the logic for the cascade delete is held in the ui and diagram plugins.

I will raise a new bug to have that code moved, and for now will disable the preference setting ( as it does nothing!)
Comment 6 Navid Mehregani CLA 2011-11-23 10:48:16 EST
The preference option is no longer there in Tigerstripe so I'm unable to reproduce the issue.  Please reopen if this is still an issue.