Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 298428 - [Theming][ToolBar] Make ToolItem align themable for vertical toolbars
Summary: [Theming][ToolBar] Make ToolItem align themable for vertical toolbars
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 1.3   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 1.3 M5   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 277883
  Show dependency tree
 
Reported: 2009-12-22 14:06 EST by Holger Staudacher CLA
Modified: 2010-01-13 12:14 EST (History)
0 users

See Also:

Attachments
fix (2.12 KB, patch)
2010-01-13 05:25 EST, Tim Buschtoens CLA 		ruediger.herrmann: iplog+
Details | Diff
Fix don't work (62.07 KB, image/png)
2010-01-13 10:37 EST, Holger Staudacher CLA 		no flags Details
additional fix (977 bytes, patch)
2010-01-13 11:48 EST, Tim Buschtoens CLA 		holger.staudacher: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Staudacher CLA 2009-12-22 14:06:12 EST 
If you create a vertical ToolBar with SWT.VERTICAL all ToolItems are centered per default. It would be nice to have an opportunity to theme this behavior.
Comment 1 Holger Staudacher CLA 2010-01-12 10:38:42 EST 
A ToolItem does not hold any reference to it's menu. So it's not possible to theme a ToolItem and at the same time it's menu. So, I will close the bug with WONTFIX now.
Comment 2 Holger Staudacher CLA 2010-01-12 11:09:37 EST 
Sorry but I closed the wrong bug. My fault... please ignore the last comment.
Comment 3 Tim Buschtoens CLA 2010-01-13 05:25:38 EST 
Created attachment 155962 [details]
fix

No theming, but vertical toolBars are automatically aligned left, while horizontal toolBars are still aligned center.
Comment 4 Rüdiger Herrmann CLA 2010-01-13 06:56:35 EST 
Applied patch to CVS HEAD
Comment 5 Holger Staudacher CLA 2010-01-13 10:37:33 EST 
Created attachment 155992 [details]
Fix don't work

It seems that the fix don't work. Take a look at the attached screen at the open bubble in the header. There is a vertical toolbar. It seems that 2 items are centered. I used the latest and greatest source from HEAD.
Comment 6 Holger Staudacher CLA 2010-01-13 10:38:09 EST 
See my comment on the attached screenshot.
Comment 7 Tim Buschtoens CLA 2010-01-13 11:48:49 EST 
Created attachment 156004 [details]
additional fix

Due to the somewhat... "unorthodox" implementation of toolItems with dropdown-arrows, the layouting of ToolItem had to be adjusted further for left-alignment.
Comment 8 Holger Staudacher CLA 2010-01-13 12:14:58 EST 
The new patch works. I have proved it and applied it to CVS HEAD.