Community
Participate
Working Groups
Created attachment 154718 [details] Standardize Statements source code. Refactoring that rewrites variables declarations, transforming them into simple statements, always containing the two points (::) that are characteristic of Fortran, making the code more readable (we should probably find a better name for this refactoring :-) ).
Hi Gustavo, Thanks for the contribution. Can you please confirm that 1. you wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others, 2. you have the right to contribute the code to Eclipse, and 3. you have included the EPL license header in all source files? (Please reply with a comment on this bug; you can just say, "I confirm that I wrote 100%..." and repeat these points. This is for our intellectual property review. For #1, if some of your code is borrowed from or based on someone else's code, please state that explicitly.) Thanks. Jeff
Created attachment 154727 [details] Standardize Statements source code (with EPL license header). Refactoring that rewrites variables declarations, transforming them into simple statements, always containing the two points (::) that are characteristic of Fortran, making the code more readable (we should probably find a better name for this refactoring :-) ).
(In reply to comment #2) > Created an attachment (id=154727) [details] > Standardize Statements source code (with EPL license header). > > Refactoring that rewrites variables declarations, transforming them into simple > statements, always containing the two points (::) that are characteristic of > Fortran, making the code more readable (we should probably find a better name > for this refactoring :-) ). (In reply to comment #1) I confirm that I wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others, and I have the right to contribute the code to Eclipse, and I have included the EPL license header in all source files. > Hi Gustavo, > > Thanks for the contribution. Can you please confirm that > > 1. you wrote 100% of the code without incorporating content from elsewhere or > relying on the intellectual property of others, > > 2. you have the right to contribute the code to Eclipse, and > > 3. you have included the EPL license header in all source files? > > (Please reply with a comment on this bug; you can just say, "I confirm that I > wrote 100%..." and repeat these points. This is for our intellectual property > review. For #1, if some of your code is borrowed from or based on someone > else's code, please state that explicitly.) > > Thanks. > Jeff
Created attachment 154733 [details] Standardize Statements source code (with correct EPL license header).
Since the contribution is fewer than 250 LOC, we will not need to go through the full IP review process for this refactoring. (Attachment is 155 LOC.)
Gustavo, Could you please add a description of this refactoring to Section 4 of the Photran 6.0 Advanced Features manual, so our users will know how to use it and what they should expect it to do? http://wiki.eclipse.org/PTP/photran/documentation/photran6advanced You can look at the descriptions of some other refactorings for examples. Thanks in advance! I will review your code and check it into CVS as soon as possible. Jeff
This refactoring has been committed to CVS, and Tim wrote some unit tests. I still need to review the code and documentation before closing this bug...
I finished the code review and made some minor coding style changes, mostly breaking it into smaller methods, renaming some things, and changing some methods to create a new object rather than modify an existing one (for clarity). Changes are in CVS. Still need to do doc review...
Done. Thanks again, Gustavo, for the refactoring! This is a very useful contribution!
