This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 297900 - fixed width font is much bigger than text font
Summary: fixed width font is much bigger than text font
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 1.3.0   Edit
Assignee: David Green CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-15 16:14 EST by Steffen Pingel CLA
Modified: 2011-01-06 10:01 EST (History)
4 users (show)

See Also:


Attachments
screenshot (90.40 KB, image/png)
2009-12-15 16:15 EST, Steffen Pingel CLA
no flags Details
patch that should fix the issue. (8.08 KB, text/plain)
2009-12-17 11:39 EST, David Green CLA
no flags Details
mylyn/context/zip (8.25 KB, application/octet-stream)
2009-12-18 10:20 EST, David Green CLA
no flags Details
mylyn/context/zip (14.79 KB, application/octet-stream)
2009-12-18 11:49 EST, David Green CLA
no flags Details
Screenshot showing different font sizes for plain text and hyperlinks (URLs) (22.25 KB, image/png)
2010-01-04 05:26 EST, Jörg Thönnes CLA
no flags Details
screenshot showing font size issue on a mac (23.80 KB, image/png)
2010-01-07 22:52 EST, David Green CLA
no flags Details
screenshot on Gtk (79.08 KB, image/png)
2010-01-08 22:48 EST, Steffen Pingel CLA
no flags Details
Screenshot showing MacOSX sizes 10 and 11 (24.40 KB, image/png)
2010-01-22 14:06 EST, David Green CLA
no flags Details
Preview and edit font differ -- how to make them identical? (40.68 KB, image/png)
2010-01-23 05:02 EST, Jörg Thönnes CLA
no flags Details
patch that sets default font size to 10, 11 on mac (1.84 KB, patch)
2010-02-19 19:43 EST, David Green CLA
no flags Details | Diff
mylyn/context/zip (40.26 KB, application/octet-stream)
2010-02-19 19:44 EST, David Green CLA
no flags Details
screenshot on Ubunutu 8.04 (19.00 KB, image/png)
2010-02-22 13:45 EST, Steffen Pingel CLA
no flags Details
mylyn/context/zip (20.42 KB, application/octet-stream)
2010-02-23 17:10 EST, David Green CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Pingel CLA 2009-12-15 16:14:18 EST
A recent change caused the proportions of the standard and fixed width font in WikiText to change (see screenshot). The fixed width font is now much bigger than the standard font on Gtk.
Comment 1 Steffen Pingel CLA 2009-12-15 16:15:07 EST
Created attachment 154527 [details]
screenshot
Comment 2 Shawn Minto CLA 2009-12-16 09:24:38 EST
Thanks for reporting this Steffen, I have been meaning to do this for a week or so but havent got around to it.  I am seeing the same problem on windows.  I think that the problem started when a preference was added for the font.
Comment 3 David Green CLA 2009-12-17 10:20:18 EST
Wow, that looks really bad!  Thanks for the bug.  Is the problem you're observing in the task editor?
Comment 4 David Green CLA 2009-12-17 10:43:06 EST
I forgot to ask: if this is in the task editor, is it in the new comment area, for existing comments, or both?
Comment 5 David Green CLA 2009-12-17 11:39:38 EST
Created attachment 154677 [details]
patch that should fix the issue.
Comment 6 David Green CLA 2009-12-17 11:40:42 EST
Steffen/Shawn can you give this patch a try and let me know if it resolves the issue?  I've tried it here and it looks good to me.  Thanks!
Comment 7 Steffen Pingel CLA 2009-12-17 15:56:22 EST
The size looks okay with the patch applied but it doesn't seem to be using a mono space font any longer.
Comment 8 David Green CLA 2009-12-18 10:20:38 EST
Created attachment 154777 [details]
mylyn/context/zip
Comment 9 David Green CLA 2009-12-18 11:49:37 EST
I've committed a fix for this, and tested on Linux.  Please try it out and let me know what you think.  The editor should now be getting the monospace font from the font preference (Tasks->Monospace Font).

While we're in there do we want to change the default size of the monospace font?  Currently it's set to 13.  I noticed that the comments/notes font size is 11.  For me, 13, looks fine on my high-resolution screen (mac) however it looks terrible when I'm running Linux at a lower resolution.
Comment 10 David Green CLA 2009-12-18 11:49:43 EST
Created attachment 154790 [details]
mylyn/context/zip
Comment 11 Steffen Pingel CLA 2009-12-23 20:42:37 EST
Thanks. That seems to work.

I agree that a size of 13 is rather big. The standard comment font is Tahoma-regular-10 (for Windows). Should we set the default mono-space size to 10 as well?

I have set it 9 on my system but I have changed my system settings to use a smaller font.
Comment 12 Jörg Thönnes CLA 2010-01-04 05:26:40 EST
Created attachment 155215 [details]
Screenshot showing different font sizes for plain text and hyperlinks (URLs)

I also see the issue with Trac, that the links are in smaller fonts, but only in the preview-mode.
See attachment. This does not happen with e.g. Bugzilla.
Comment 13 Jörg Thönnes CLA 2010-01-04 05:28:27 EST
Will the provided patch correct this issue?

Is there any workaround or have I just wait for the next weekly build?

Thanks, Jörg
Comment 14 Steffen Pingel CLA 2010-01-04 13:16:18 EST
I'll create another weekly build. That should allow you to modify the font size through the preferences until we have settled on a new default size.
Comment 15 Jörg Thönnes CLA 2010-01-05 08:44:35 EST
(In reply to comment #14)
> I'll create another weekly build. That should allow you to modify the font size
> through the preferences until we have settled on a new default size.

Thanks, Steffen. Just updated to the new weekly build.

But I wonder how I could adjust the font sizes. I checked all fonts in the "Colors and fonts" preferences
and all are set to either "Sans Serif 7" or "Monospace 7". But the hyper-linked text still shows up in a larger font (the font used by the WikiText editor). If I switch to preview-mode or look at the already submitted comments, the normal text is using the font size 7, but the hyper-linked text stays at the larger font (see already attached screen shot). Is this another bug?
Comment 16 David Green CLA 2010-01-07 22:52:45 EST
Created attachment 155569 [details]
screenshot showing font size issue on a mac
Comment 17 David Green CLA 2010-01-07 22:53:24 EST
the last screenshot was from bug 298626
Comment 18 Steffen Pingel CLA 2010-01-08 22:48:14 EST
Created attachment 155643 [details]
screenshot on Gtk
Comment 19 Steffen Pingel CLA 2010-01-08 22:50:16 EST
It works for me if I change the Task Editor - Monospace Font in the Tasks category.
Comment 20 Mik Kersten CLA 2010-01-14 13:16:06 EST
For Windows, I think we should set a default of 10px for both fixed and variable width.
Comment 21 Steffen Pingel CLA 2010-01-14 18:40:52 EST
Looks like the default Gtk Theme uses size 10 for dialogs on Ubuntu 8.04.  A font size of 10 for both looks good but if we wanted to make the task editor notes font more concise by default we should go with 9 for both.
Comment 22 David Green CLA 2010-01-14 23:04:59 EST
Size 11 looks good on Mac OS X
Comment 23 Mik Kersten CLA 2010-01-20 23:20:02 EST
David, Rob: Just curious, how does size 10 look on OS X?  Could you post screenshots of both?  Just wondering since it could make sense to have a consistent default across the OSes, but only if it's balanced with the other fonts.
Comment 24 David Green CLA 2010-01-22 14:06:32 EST
Created attachment 156972 [details]
Screenshot showing MacOSX sizes 10 and 11

Attached screenshot comparing size 10 and size 11 fonts on Mac OS X side by side.  I like size 11 more (it looks like size 10 is not antialiased)
Comment 25 David Green CLA 2010-01-22 14:06:59 EST
Here's a test comment for showing monospace font

pre{color:red}. 
See here it is!  Monospace Monospace Monospace Monospace Monospace Monospace 
BTW, notice how easy it is to make text stand out with color?
  def
  ghi
  
Test complete, this is now regular font.
Comment 26 Jörg Thönnes CLA 2010-01-23 05:02:24 EST
Created attachment 157028 [details]
Preview and edit font differ -- how to make them identical?
Comment 27 Jörg Thönnes CLA 2010-01-23 05:02:52 EST
Looking at the font preference menu, the Task Editor section has two fonts:
* Task Editor - Monospace font
* Task Editor - Notes and Comments

I was not aware of the second font since I always put the keyword "font" into the quick filter.
But the second entry is not matched -- please rename it to "Notes and Comments font"

In addition, with regard to the "WikiText Text Font":

1. What means "overrides default..." instead of "set to default" as in other places
2. The preview shows "Sans 7" but if I click edit it shows "Sans 12"!
3. Changing it to "Sans 7" keeps the preview, but nothing does happen in new editor panes.
4. Also playing around setting to size 8 and then back 7 does not change anything.

So I wonder how I could set my WikiText Text Font???

I attached a screen shot.
Comment 28 David Green CLA 2010-02-12 10:53:00 EST
Everyone: let's get this font size issue wrapped up.  I'm looking for feedback on preferred default font size for each supported platform.  The font size should be the same as the task comment default size.

Currently the task comment default font size per-platform is Tahoma-regular-10 on Win 32, otherwise defaults to the dialog font which is Lucida Grande 13 on Mac OS X.

What I suggest for Mac is size 11 for both monospace and regular font.
Comment 29 Robert Elves CLA 2010-02-18 13:20:16 EST
+1 for 11 on Mac
Comment 30 David Green CLA 2010-02-18 13:21:56 EST
From the call:

* Linux - 10
* Mac - 11
* Win32 - 10
Comment 31 David Green CLA 2010-02-19 19:43:52 EST
Created attachment 159637 [details]
patch that sets default font size to 10, 11 on mac

Any chance I could get Windows, Mac and Linux users to try out this patch?  It sets the default font size to 10 for linux and windows, 11 on Mac.
Comment 32 David Green CLA 2010-02-19 19:44:08 EST
Created attachment 159638 [details]
mylyn/context/zip
Comment 33 Jörg Thönnes CLA 2010-02-20 03:35:05 EST
(In reply to comment #31)
> Any chance I could get Windows, Mac and Linux users to try out this patch?  It sets the default font size to 10 for linux and windows, 11 on Mac.

How about a weekly build?
Comment 34 Steffen Pingel CLA 2010-02-22 13:45:46 EST
Created attachment 159829 [details]
screenshot on Ubunutu 8.04
Comment 35 David Green CLA 2010-02-23 10:35:53 EST
Thanks for the screenshot.  Do you like what you see or are there any problems that I'm not noticing?
Comment 36 Steffen Pingel CLA 2010-02-23 11:17:12 EST
It looks reasonable to me. It might be easiest if you go ahead and commmit the patch. We can still make adjustments if necessary.
Comment 37 David Green CLA 2010-02-23 17:10:52 EST
Patch committed.  Please reopen this issue if required.

Joerg please open new bugs if needed pertaining to your comment #27
Comment 38 David Green CLA 2010-02-23 17:10:59 EST
Created attachment 160004 [details]
mylyn/context/zip