Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 297728 - [Filters] IFileInfoMatcherDescription and FileInfoMatcherDescription cleanup
Summary: [Filters] IFileInfoMatcherDescription and FileInfoMatcherDescription cleanup
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Resources (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.6 M5   Edit
Assignee: Szymon Brandys CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 291755
  Show dependency tree
 
Reported: 2009-12-14 07:49 EST by Szymon Brandys CLA
Modified: 2009-12-21 05:34 EST (History)
2 users (show)

See Also:

Attachments
Fix v01 (core.resources) (32.04 KB, patch)
2009-12-14 08:01 EST, Szymon Brandys CLA 		no flags Details | Diff
Fix v01 (ui) (5.05 KB, patch)
2009-12-14 08:02 EST, Szymon Brandys CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Szymon Brandys CLA 2009-12-14 07:49:28 EST 
Users should not be allowed to modify matcher descriptions once they are used in any resource filter. Right now IFileInfoMatcherDescription has setters what is not right, since setting new id or arguments on the matcher doesn't affect the filter.

We can either create kind of a factory for creating IFileInfoMatcherDescription objects, remove setters from IFileInfoMatcherDescription and make the default implementation FileInfoMatcherDescription non-API,
or get rid of IFileInfoMatcherDescription and use immutable FileInfoMatcherDescription objects (initialization in constructor and getters only).
Comment 1 Szymon Brandys CLA 2009-12-14 08:01:29 EST 
Created attachment 154401 [details]
Fix v01 (core.resources)
Comment 2 Szymon Brandys CLA 2009-12-14 08:02:16 EST 
Created attachment 154402 [details]
Fix v01 (ui)
Comment 3 Szymon Brandys CLA 2009-12-21 05:34:47 EST 
Both patches released to HEAD.