Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 297702 - [Commands] command handler extensions are unnamed in the editor
Summary: [Commands] command handler extensions are unnamed in the editor
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5.1   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 4.2 M7   Edit
Assignee: Paul Webster CLA
QA Contact: Paul Webster CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-13 16:42 EST by Jeff McAffer CLA
Modified: 2012-05-01 14:24 EDT (History)
3 users (show)

See Also:

Attachments
Proposed patch in org.eclipse.ui/schema/handlers.exsd (656 bytes, patch)
2010-07-20 14:23 EDT, Patrick Tasse CLA 		no flags Details | Diff
patch (695 bytes, patch)
2010-07-20 15:22 EDT, Darin Wright CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff McAffer CLA 2009-12-13 16:42:57 EST 
In 3.4, and 3.5 there is a problem when you have multiple handler extensions defined. The extension editor only shows (handler) in the master pane rather than showing the name of the handler.  This is a real usability problem for people who have even a modest number of handlers defined.  Even the PDE help has a screen shot that shows this condition.  While this behaviour may be on purpose, Chris indicates that there is something about taking the first attribute in the schema and displaying it.  So you may want to punt to the definer of the handler extension point but either way, this is a real problem for people trying to develop with handlers.
Comment 1 Patrick Tasse CLA 2010-07-20 14:23:03 EDT 
Created attachment 174774 [details]
Proposed patch in org.eclipse.ui/schema/handlers.exsd

I believe this will do the trick. It is untested.

Legal Message: I, Patrick Tassé, declare that I developed attached code from scratch, without referencing any 3rd party materials except material licensed under the EPL. I am authorized by my employer to make this contribution under the EPL.
Comment 2 Darin Wright CLA 2010-07-20 15:22:32 EDT 
Created attachment 174782 [details]
patch

Updated patch. The label attribute has to go inside the <annotation> tag.
Comment 3 Darin Wright CLA 2010-07-20 15:23:21 EDT 
Moving to Platform UI, patch applies to org.eclipse.ui bundle.
Comment 4 Paul Webster CLA 2012-04-03 14:57:32 EDT 
I looked into applying this patch, and I believe there has been an update in PDE.  If I open the PDE editor Extensions org.eclipse.ui.handlers it now shows them as "commandId (handler)"

Patrick, can you confirm?

PW
Comment 5 Patrick Tasse CLA 2012-04-03 15:45:26 EDT 
Yes, it seems it's fixed in 3.7.2. I'm still using 3.7.1...
Comment 6 Paul Webster CLA 2012-04-03 15:54:42 EDT 
If you'd still like me to apply it, I'll go ahead, but it won't show up until 3.8/4.2.

PW
Comment 7 Patrick Tasse CLA 2012-04-05 11:10:13 EDT 
It's been so long, I forgot how to reproduce the problem...

Actually the commandId is shown in the tree only if the class is not set (empty).

Once you define a class, then the tree starts showing only "(handler)". At least it still does in 3.7.2.

So perhaps the patch is still required (if you can test that it solves the issue).
Comment 8 Paul Webster CLA 2012-04-05 11:44:47 EDT 
(In reply to comment #7)
> Actually the commandId is shown in the tree only if the class is not set
> (empty).
> 

OK, sounds like it still needs to be done.  Thanx Patrick, when we get an I build I'll ask you to have a quick look to verify it.

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=f79200390abc71fd14de022f816c5b15ad4bd025

PW
Comment 9 Michael Rennie CLA 2012-05-01 14:24:05 EDT 
verified in:

Version: 4.2.0
Build id: I20120430-1800