Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 297268 - CompareContentViewerSwitchingPane shows popup menu twice on Cocoa
Summary: CompareContentViewerSwitchingPane shows popup menu twice on Cocoa
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 3.6   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: 3.6 M7   Edit
Assignee: Platform-Compare-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 246843
Blocks:
  Show dependency tree
 
Reported: 2009-12-08 15:58 EST by Markus Keller CLA
Modified: 2010-04-26 06:02 EDT (History)
2 users (show)

See Also:

Attachments
Fix (1.40 KB, patch)
2009-12-08 15:58 EST, Markus Keller CLA 		no flags Details | Diff
Fix 2 (1.37 KB, patch)
2009-12-08 16:20 EST, Markus Keller CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2009-12-08 15:58:22 EST 
Created attachment 154056 [details]
Fix

HEAD

CompareContentViewerSwitchingPane#createTopLeft(Composite) creates a toolbar
for a popup menu to switch content types. This popup menu is shown twice on
Cocoa (first time after I release the mouse button, second time after the first
menu  got closed).

That's because that method adds a mouse listener to the toolbar and a selection
listener to the tool item, and both open the menu.

On WinXP, the selection event is never sent out because the menu already opens
on mouseDown. On Cocoa, the menu only opens on mouseUp (bug 246843), and the
selection event is also sent out.
Comment 1 Markus Keller CLA 2009-12-08 16:02:15 EST 
Comment on attachment 154056 [details]
Fix

Fix is not good. Better one follows.
Comment 2 Markus Keller CLA 2009-12-08 16:20:40 EST 
Created attachment 154066 [details]
Fix 2

Better fix.

The first one broke keyboard access (only on accessible platforms -- not applicable to the Mac, see bug 276566).
Comment 3 Markus Keller CLA 2010-03-19 12:55:22 EDT 
Could you please release the patch?
Comment 4 Pawel Pogorzelski CLA 2010-03-22 09:14:06 EDT 
Patch in HEAD. Marking as FIXED. Thanks for the patch Markus.
Comment 5 Pawel Pogorzelski CLA 2010-04-26 06:02:54 EDT 
Marking as FIXED.