Community
Participate
Working Groups
Created attachment 154053 [details] Patch for the above Currently if I create a new git repo, right-click the project folder, and click 'Commit...' without adding anything to version control, I will be told that no files were selected and asked if I wish to amend a previous commit. However, there are no previous commits. The proposed patch moves up a call to loadPreviousCommit so that EGit can tell in advance whether or not a previous commit is available. It is up to you whether or not to keep the error message about amends not possible in this case, I have left it in. Sorry for not using Gerrit, but your wiki claims that submitting a patch this way is also okay? Please feel free to let me know if I have committed any faux pas. :) -Charley
(In reply to comment #0) > However, there are no previous commits. The proposed patch moves up a call to > loadPreviousCommit so that EGit can tell in advance whether or not a previous > commit is available. It is up to you whether or not to keep the error message > about amends not possible in this case, I have left it in. Thank you, Charley. It seems ok, but I'll take a closer look at it later today. > Sorry for not using Gerrit, but your wiki claims that submitting a patch this > way is also okay? In most cases it's true. But not when it has not been marked as a patch and it's MIME Type is 'application/octet-stream' instead of 'plain/text';-)
Created attachment 154243 [details] Proposed patch for the above Apologies :) here it is in plain text.
Charley: I uploaded your change to Gerrit for easier review: http://egit.eclipse.org/r/#change,142 Please register here to participate in the code review : http://egit.eclipse.org/register -- Matthias
Created attachment 157848 [details] Patch with expanded error message Slight modification to the error message produced.
Pushed.
