Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 297194 - [modeling] Do nothing when no object has been created
Summary: [modeling] Do nothing when no object has been created
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: Incubators (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Benjamin Cabé CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-08 08:15 EST by Sebastien Moran CLA
Modified: 2009-12-08 11:57 EST (History)
1 user (show)

See Also:

Attachments
Patch to authorize AddAction cancelation (975 bytes, patch)
2009-12-08 08:16 EST, Sebastien Moran CLA 		contact: iplog+
Details | Diff
mylyn/context/zip (2.67 KB, application/octet-stream)
2009-12-08 11:53 EST, Benjamin Cabé CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastien Moran CLA 2009-12-08 08:15:01 EST 
The default AbstractAddAction used in the EmfMasterDetailBlock does not check that the created Object is not null. But sometimes you may need to abort the AddAction by returning a null value.

The attached patch just do nothing when the returned value is null.
Comment 1 Sebastien Moran CLA 2009-12-08 08:16:16 EST 
Created attachment 154000 [details]
Patch to authorize AddAction cancelation
Comment 2 Benjamin Cabé CLA 2009-12-08 11:52:23 EST 
Released, with a small update on the javadoc of createNewObject().
Thanks Sebastien!
Comment 3 Benjamin Cabé CLA 2009-12-08 11:53:23 EST 
Created attachment 154030 [details]
mylyn/context/zip
Comment 4 Benjamin Cabé CLA 2009-12-08 11:57:15 EST 
forgot to mark as FIXED...