Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 297056 - [publisher] Product publisher doesn't honor splash location default semantics in product configuration
Summary: [publisher] Product publisher doesn't honor splash location default semantics...
Status: RESOLVED WONTFIX
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: P2 Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 274127
  Show dependency tree
 
Reported: 2009-12-07 05:45 EST by Christian K. CLA
Modified: 2020-02-24 00:48 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christian K. CLA 2009-12-07 05:45:04 EST
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.5) Gecko/20091102 Firefox/3.5.5 (.NET CLR 3.5.30729)
Build Identifier: 3.5.1 M20090917-0800

I'm using PDE Build to build a product with p2.gathering enabled. The product also includes brnading and a launcher. The problem is when I test/launch the build result the splash screen is not shown. This is obviously caused by a missing osgi.splashLocation entry in the config.ini. This in turn seems to be caused by the product publisher.

Up to now I was relying on the default sematics for the splash location in the product configuration which is:
"If its location is not specified, the 'splash.bmp' file is assumed to be in the product's defining plug-in."

It seems like this is not honored by the product publisher. If nothing is specified in the product configuration the publischer just leaves out the osgi.splashLocation entry.

I found out about this by digging thru the code, the code snippet that lead me to this bug is in org.eclipse.equinox.p2.publisher.eclipse.ProductFileAdvice#getConfigData():

If I understand that code correctly the osgi.splashLocation is only added when the location is set, i.e. it is not null.

Reproducible: Always

Steps to Reproduce:
1. Create a PDE product build with p2.gathering enabled
2. Use an empty splash location assuming that the default will be used
3. Launch the build result -> splash will not be shown
Comment 1 Andrew Niefer CLA 2009-12-07 11:31:35 EST
See pde.build's ProductGenerator#getSplashLocation for details of using the defining plugin as default.

linking to 274127 as a main reference for splash bugs
Comment 2 Eclipse Webmaster CLA 2019-09-06 15:32:20 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
Comment 3 Ed Merks CLA 2020-02-24 00:48:18 EST
This doesn't appear to be a p2 issue but a PDE build issue.  If the problem is current, reopen it again PDE.