Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 296853 - AGR test invocations to external tests/suites do not include external object mine.
Summary: AGR test invocations to external tests/suites do not include external object ...
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P2 normal (vote)
Target Milestone: ---   Edit
Assignee: Paul Slauenwhite CLA
QA Contact: Kathy Chan CLA
URL:
Whiteboard: bvt
Keywords:
Depends on: 136186
Blocks: 211751
  Show dependency tree
 
Reported: 2009-12-03 14:27 EST by Paul Slauenwhite CLA
Modified: 2016-05-05 11:08 EDT (History)
2 users (show)

See Also:

Attachments
Patch. (22.64 KB, patch)
2009-12-03 14:28 EST, Paul Slauenwhite CLA 		no flags Details | Diff
Patch (Part 2 - Version 1). (37.41 KB, patch)
2009-12-07 10:25 EST, Paul Slauenwhite CLA 		no flags Details | Diff
Patch (Part 2 - Version 2). (14.45 KB, patch)
2009-12-07 10:26 EST, Paul Slauenwhite CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Slauenwhite CLA 2009-12-03 14:27:23 EST 
AGR test invocations to external tests/suites do not include external object mine.

The problem is that only the object mine for the root test suite is used and not the object mines for the referenced test suites.  

For example, /org.eclipse.hyades.tests/BVT/AllBVTGUITests_Sun_JRE_160.testsuite.

Work-around: Include the object mines for ALL referenced test suites in the object mine for the root test suite.  However, this is problematic when there is a hierarchy of test suites.
Comment 1 Paul Slauenwhite CLA 2009-12-03 14:28:22 EST 
Created attachment 153769 [details]
Patch.
Comment 2 Paul Slauenwhite CLA 2009-12-03 14:29:11 EST 
The attached patch checked in to CVS (HEAD).
Comment 3 Paul Slauenwhite CLA 2009-12-04 12:28:08 EST 
Patch causes the following exception in the BVTs:

java.lang.StringIndexOutOfBoundsException: String index out of range: -26

	at java.lang.String.substring(String.java:1938)

	at org.eclipse.tptp.test.auto.gui.internal.runner.ExtendedScriptParser.parse(ExtendedScriptParser.java:97)

	at org.eclipse.tptp.test.auto.gui.internal.runner.AutoGUIRunner.parseTestScript(AutoGUIRunner.java:1263)

	at org.eclipse.tptp.test.auto.gui.internal.runner.AutoGUIRunner.earlyStartup(AutoGUIRunner.java:281)

	at org.eclipse.ui.internal.EarlyStartupRunnable.runEarlyStartup(EarlyStartupRunnable.java:87)

	at org.eclipse.ui.internal.EarlyStartupRunnable.run(EarlyStartupRunnable.java:66)

	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)

	at org.eclipse.ui.internal.Workbench$55.run(Workbench.java:2192)

	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
Comment 4 Paul Slauenwhite CLA 2009-12-07 10:25:48 EST 
Created attachment 153926 [details]
Patch (Part 2 - Version 1).
Comment 5 Paul Slauenwhite CLA 2009-12-07 10:26:20 EST 
Created attachment 153927 [details]
Patch (Part 2 - Version 2).
Comment 6 Paul Slauenwhite CLA 2009-12-07 10:27:57 EST 
Patch part 2 - version 2 resolves the original issue without modifying the test script.

Patch part 2 - version 2 checked in to CVS (HEAD).
Comment 7 Paul Slauenwhite CLA 2010-01-07 11:30:14 EST 
Verified with the latest BVT run (see http://www.eclipse.org/tptp/home/downloads/BVT.php?version=4.6.2&buildID=TPTP-4.6.2-201001051032) since required to run the BVTs.

Closing.