Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 296678 - [modeling] Creation menu filters are not correctly updated when they are different between two pages
Summary: [modeling] Creation menu filters are not correctly updated when they are diff...
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: Incubators (show other bugs)
Version: 3.6   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Benjamin Cabé CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-02 06:13 EST by Jacques LESCOT CLA
Modified: 2009-12-02 06:26 EST (History)
1 user (show)

See Also:


Attachments
Bug fix + necessary API changes (4.78 KB, patch)
2009-12-02 06:13 EST, Jacques LESCOT CLA
contact: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jacques LESCOT CLA 2009-12-02 06:13:02 EST
We need to update filters associated with "createChild" menu and "createSibling" menu when the filters defined at the page level are different. In the attached patch, the update is done when a new page is activated.

To ensure a correct update of these filters, it is necessary to access the underlying EmfMasterDetailBlock contents. Thus, I had to modify the API related to the isMasterDetail flag : instead, I created a getMainMasterDetailBlock() method that should be overridden by subclasses when a EmfMasterDetailBlock is used as the contents of the page.

Note that the issue also depends on the issue 296676, since it needs to access to public methods.
Comment 1 Jacques LESCOT CLA 2009-12-02 06:13:51 EST
Created attachment 153575 [details]
Bug fix + necessary API changes
Comment 2 Benjamin Cabé CLA 2009-12-02 06:25:32 EST
Thanks Jacques, patch applied.