Community
Participate
Working Groups
Created attachment 153397 [details] Patch My pluign contributs its own Annotations, Markers and Marker resolutions, when these markers get created on MF file, the Quick fix icon shows up but wheni click on none of my quick fix show up I did invistigate the problem and foudn that, my resolution generators goes not get called at all, and the is the way the PDEQuickAssistProcessor works PDEQuickAssistProcessor, will use IDE.getMarkerHelpRegistry().getResolutions to get teh resolutions for specific markers which should trigger my generators, but the issue is that it calles this method inside the canFix method this will not work for all cases becuase the DefaultMarkerAnnotationAccess will call this method only if there is no IAnnotationImageProvider - see getImage implementation - in my case I have an Annotation Image provider registers (to provide my own images for my markers) as a result canFix will not be called on the PDEQuickAssistProcessor which will cause computeQuickAssistProposals to find no proposals Attached a propsed patch to fix the issue, by seperating the data model propagation from the can fix method
What are your contributing to the MANIFEST.MF? :)? I think this is a reasonable request. However, I'd like to know what you're contributing first and if it makes sense for it to be rolled down into PDE.
(In reply to comment #1) > What are your contributing to the MANIFEST.MF? :)? > > I think this is a reasonable request. > > However, I'd like to know what you're contributing first and if it makes sense > for it to be rolled down into PDE. Hi ; yes i'm contributing to the MANIFEST.MF basically my product does static analysis, and some of the analysis result are reported for MANIFEST.MF, and i dod offer quick fixes for these results but becuase of this issues my quick fixes do not show upo, unless i do that change in the patchi assigned to the bug
Thanks for the patch Mohammed. > 20091231
Created attachment 155163 [details] mylyn/context/zip
This patch has deleted a fix I added at PDEQuickAssistAssistant Line 168 for Bug 154292. Was it intentional?
Does it break your fix?
it did. But since the same problem (duplicate resolutions) resurfaced from some other place I will be fixing it anyway.
(In reply to comment #7) > it did. But since the same problem (duplicate resolutions) resurfaced from some > other place I will be fixing it anyway. Great, sounds like a plan. We want to make sure we allow for custom contributions still.
