Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 296506 - [Webapp] Quick search of Toc only searches subtopics
Summary: [Webapp] Quick search of Toc only searches subtopics
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6 M4   Edit
Assignee: Hao Zhang CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-30 14:01 EST by Chris Goldthorpe CLA
Modified: 2009-12-01 15:14 EST (History)
0 users

See Also:

Attachments
Test Project (6.51 KB, application/octet-stream)
2009-11-30 14:06 EST, Chris Goldthorpe CLA 		no flags Details
Patch V1 (859 bytes, patch)
2009-12-01 00:25 EST, Hao Zhang CLA 		cgold: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Goldthorpe CLA 2009-11-30 14:01:20 EST 
I20091029-0840

If a toc element has an href attribute that page is not searched in a quick search of "Selected topic and all subtopics".
Comment 1 Chris Goldthorpe CLA 2009-11-30 14:06:01 EST 
Created attachment 153375 [details]
Test Project

To test 
1. Unzip and add this project to your workspace
2. Launch Eclipse
3. Help/Help Contents
4. Select the book "Quick Search Test"
5. Search selected topic and all subtopics for "enter"

Expected result, there are three search hits
Actual result, there are only two search hits. org.eclipse.help.qsearchtest/html/toc.html is missing from the results.
Comment 2 Chris Goldthorpe CLA 2009-11-30 14:32:20 EST 
Vivian can you take a look at this bug?
Comment 3 Hao Zhang CLA 2009-12-01 00:25:25 EST 
Created attachment 153415 [details]
Patch V1

In class AdaptableToc, method getTopic will miss the toc element.
So quick search on Toc will not include the result on Toc element.

After modifying the method, the bug is fixed now.
Comment 4 Chris Goldthorpe CLA 2009-12-01 15:14:07 EST 
Patch committed to HEAD, Fixed.