Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 296454 - [DnD] Improve Transfer-Support
Summary: [DnD] Improve Transfer-Support
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 1.3   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.3 M5   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 285390
  Show dependency tree
 
Reported: 2009-11-30 06:48 EST by Tim Buschtoens CLA
Modified: 2009-12-14 09:10 EST (History)
1 user (show)

See Also:

Attachments
fix (33.88 KB, patch)
2009-12-11 11:13 EST, Tim Buschtoens CLA 		ruediger.herrmann: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Buschtoens CLA 2009-11-30 06:48:31 EST 
Currently the field DropTargetEvent.dataType can not be changed in the dragEnter/dragOver events. Also, the Transfers are compared on the client using only the classname instead of the type-id. Therefore, Transfers that are not identical but compatible are not recognized.
Comment 1 Tim Buschtoens CLA 2009-12-11 11:13:42 EST 
Created attachment 154314 [details]
fix

Fix including tests. 
There is one deviation from the SWT-behavior: If the application-code sets "currentTransferType" to null or a invalid value, it is reverted to a valid value in RAP, while in SWT it is set to null and the DROP_NONE-cursor is displayed.
Comment 2 Tim Buschtoens CLA 2009-12-11 11:17:49 EST 
I keep mixing those up: In the description i mean "currentDataType", not "dataType", and in comment 1 i also mean "currentDataType", not "currentTransferType". (Neither "dataType" nor "currentTransferType" actually exist in dropTargetEvent. )
Comment 3 Rüdiger Herrmann CLA 2009-12-14 09:09:47 EST 
Applied patch to CVS HEAD