This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 296436 - [releng] Include tests in the developer resources bundles
Summary: [releng] Include tests in the developer resources bundles
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: 3.5   Edit
Assignee: Steffen Pingel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 305782
  Show dependency tree
 
Reported: 2009-11-30 04:11 EST by Robert Munteanu CLA
Modified: 2011-02-09 18:35 EST (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Munteanu CLA 2009-11-30 04:11:02 EST
It has often been said that the best way of finding out how to create a repository connector for Mylyn is to look at the source of the existing connectors. The SDK bundles offer a very convenient way of getting the sources, without having to checkout and track the Mylyn CVS repositories.

One item which is missing from them are the test projects, which contain good indicators on how to write the test suites, which are critical for quality connectors.

Please consider including the test projects in the SDK bundles.
Comment 1 Steffen Pingel CLA 2009-11-30 13:55:45 EST
That's an interesting idea. Most Eclipse SDKs don't seem to include tests as they can get very big particularly if there is lots of mock data. I have noticed that other projects such as WTP provide separate features with tests though. What are others thoughts about providing test bundles?
Comment 2 David Green CLA 2009-12-01 15:29:28 EST
Maintaining a separate update site and features for unit tests seems a little over the top to me.  Developers have full access to source code -- why is it better to distribute tests via a bundle+feature rather than via CVS?

IMHO it's unlikely that we'll want to distribute separate test bundles via the standard update site.  There will also be extra effort/complexity involved in maintaining these bundles and features.  Testing infrastructure should be as lightweight as possible in order to better encourage creation of unit tests.
Comment 3 Robert Munteanu CLA 2009-12-01 15:37:50 EST
(In reply to comment #2)
> Developers have full access to source code -- why is it
> better to distribute tests via a bundle+feature rather than via CVS?

As a connector developer, I do have access to source code, but it's much more convenient to use the SDK bundles, since:

* I always have a version which matches my workspace installation;
* It's easier to upgrade to a newer version;
* There is no confusion over new projects being added;
* Getting the bundles is much faster - usually from a local Eclipse mirror.
Comment 4 Steffen Pingel CLA 2009-12-01 22:18:16 EST
We have the build infrastructure in place for creating a feature that contains all unit tests. This feature is used to run nightly test so the additional cost of publishing that to an update site should be fairly low.

Robert, how do you currently use the SDK features? Do you import Mylyn bundles as binaries with linked content? Would one Test feature with all tests do or would you expect separate features (e.g. for the main, extras and incubator)?
Comment 5 Robert Munteanu CLA 2009-12-02 05:17:29 EST
(In reply to comment #4)

> Robert, how do you currently use the SDK features? Do you import Mylyn bundles
> as binaries with linked content? Would one Test feature with all tests do or
> would you expect separate features (e.g. for the main, extras and incubator)?

Yes, I import the Mylyn bundles as binaries with linked content. As for the test feature, I believe just one would do nicely.
Comment 6 Steffen Pingel CLA 2010-01-09 03:07:28 EST
The Mylyn SDK is included in the RCP package and we need to consider the size of the feature. I think it would be fine to make the tests available in a separate tests feature. My sense is that most projects do it that way since it's less likely that developers look at tests if they are just integrating rather than modifying the source (in which case you would probably get it from cvs). 

Robert, would it be sufficient if we made tests available in a separate feature? We might leave that uncategorized to prevent users from accidentally installing it.
Comment 7 Robert Munteanu CLA 2010-01-09 07:34:02 EST
(In reply to comment #6)
> Robert, would it be sufficient if we made tests available in a separate feature?
> We might leave that uncategorized to prevent users from accidentally installing
> it.

That would be great.
Comment 8 Steffen Pingel CLA 2011-02-08 19:57:28 EST
I have added a "Mylyn Tests SDK" feature to the new weekly update site: http://download.eclipse.org/mylyn/snapshots/weekly/ .
Comment 9 Steffen Pingel CLA 2011-02-09 05:37:07 EST
Reopening to address dependency problem:

  Software being installed: Mylyn Tests SDK 3.5.0.I20110209-0414 (org.eclipse.mylyn.test_feature.feature.group 3.5.0.I20110209-0414)
  Missing requirement: Mylyn Tests 3.5.0.I20110209-0414 (org.eclipse.mylyn.tests 3.5.0.I20110209-0414) requires 'bundle org.eclipse.mylyn.hudson.tests 0.0.0' but it could not be found
  Cannot satisfy dependency:
    From: Mylyn Tests SDK 3.5.0.I20110209-0414 (org.eclipse.mylyn.test_feature.feature.group 3.5.0.I20110209-0414)
    To: org.eclipse.mylyn.tests [3.5.0.I20110209-0414]

  Software being installed: Mylyn Tests SDK 3.5.0.I20110209-0414 (org.eclipse.mylyn.test_feature.feature.group 3.5.0.I20110209-0414)
  Missing requirement: Mylyn UI Tests 3.5.0.I20110209-0414 (org.eclipse.mylyn.tests.ui 3.5.0.I20110209-0414) requires 'bundle org.eclipse.swtbot.eclipse.core 2.0.0' but it could not be found
  Cannot satisfy dependency:
    From: Mylyn Tests SDK 3.5.0.I20110209-0414 (org.eclipse.mylyn.test_feature.feature.group 3.5.0.I20110209-0414)
    To: org.eclipse.mylyn.tests.ui [3.5.0.I20110209-0414]
Comment 10 Steffen Pingel CLA 2011-02-09 18:35:45 EST
Removed org.eclipse.mylyn.tests plug-in from feature.