This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 296391 - Contributing EclipseLink Logger bridge over SLF4J
Summary: Contributing EclipseLink Logger bridge over SLF4J
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Eclipselink (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement with 9 votes (vote)
Target Milestone: ---   Edit
Assignee: Nobody - feel free to take it CLA
QA Contact:
URL:
Whiteboard: submitted_patch
Keywords:
Depends on:
Blocks: 454792 494612
  Show dependency tree
 
Reported: 2009-11-27 18:30 EST by Jaro Kuruc CLA
Modified: 2022-06-09 10:27 EDT (History)
7 users (show)

See Also:

Attachments
EclipseLink Logger bridge over SLF4J (5.99 KB, application/octet-stream)
2009-11-27 18:30 EST, Jaro Kuruc CLA 		no flags Details
Unit tests (5.26 KB, application/octet-stream)
2009-11-28 03:37 EST, Jaro Kuruc CLA 		no flags Details
EclipseLink SLF4J logger (1.54 MB, patch)
2015-07-30 07:10 EDT, Tomas Kraus CLA 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jaro Kuruc CLA 2009-11-27 18:30:53 EST 
Created attachment 153292 [details]
EclipseLink Logger bridge over SLF4J

I'd like to contribute my implementation of EclipseLink Logger bridge over
SLF4J. It would be great if you could include it in EclipseLink Core, as SLF4J
is becoming widely adopted across the OS community. Thanks.
Comment 1 Jaro Kuruc CLA 2009-11-28 03:37:30 EST 
Created attachment 153298 [details]
Unit tests

Tested using:
 * Commons Lang 2.4
 * JUnit 4.5
 * SLF4J 1.5.6
 * LogBack Classic 0.9.15
 * Hamcrest 1.1
Comment 2 Gunnar Wagenknecht CLA 2013-10-24 09:33:54 EDT 
+1, would be good to have this available right in the fw
Comment 3 Terence Kent CLA 2014-01-31 11:19:08 EST 
+1 from here too, I think this is a pretty commonly need thing.

While it's easy enough to copy/re-write this SessionLog implementation when you need it, it would be much more convenient if it was included with the distribution.
Comment 4 Mauro Molinari CLA 2014-11-11 07:02:34 EST 
+1 from me too.
Comment 5 Tomas Kraus CLA 2015-07-09 07:40:09 EDT 
Unfortunately this old patch is not working properly with current EclipseLink and SL4J/logback jars. Working on fixing it.
Comment 6 Tomas Kraus CLA 2015-07-30 07:10:01 EDT 
Created attachment 255532 [details]
EclipseLink SLF4J logger

This changeset was pushed into master:
--------------------------------------
http://git.eclipse.org/c/eclipselink/eclipselink.runtime.git/commit/?id=dcddcca8957380345b981ce9cba11104667032cc

Closing this issue.
Comment 7 Tomas Kraus CLA 2015-07-30 07:13:32 EDT 
CQs covering 3rd party libraries:
---------------------------------
  CQ 9981 SLF4J API Version: 1.7.2
  CQ 9982 Logback Core Version: 1.0.7
  CQ 9983 Logback Classic Version: 1.0.7

All CQs were approved.

I know that those versions are not latest available but they are already available for Tycho build.
We may request libraries update later.
Comment 8 Eclipse Webmaster CLA 2022-06-09 10:27:28 EDT 
The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink