This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 295605 - Remove the "e4" menu items from the E4 SDK
Summary: Remove the "e4" menu items from the E4 SDK
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 1.0 RC3   Edit
Assignee: Paul Webster CLA
QA Contact: Paul Webster CLA
URL:
Whiteboard:
Keywords:
: 298011 299842 318244 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-11-19 10:18 EST by Oleg Besedin CLA
Modified: 2010-07-20 16:59 EDT (History)
7 users (show)

See Also:
bokowski: review+


Attachments
Patch with new command that opens web page (2.98 KB, text/plain)
2009-12-16 17:23 EST, Dan Rubel CLA
no flags Details
Add new menu items to open web page v02 (4.46 KB, patch)
2010-07-19 21:04 EDT, Paul Webster CLA
no flags Details | Diff
remove e4 menu v01 (9.12 KB, patch)
2010-07-20 14:30 EDT, Paul Webster CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg Besedin CLA 2009-11-19 10:18:58 EST
The I20091119-0815 E4 SDK has "e4" menu on the main menu bar:
 "Generate E4 example project"
 "UI Editor"
 "Reload Style Sheet"

I don't think those menu items work.
Comment 1 Paul Webster CLA 2009-11-19 10:58:50 EST
Correct, because now they're 3.6 menu items that depend on e4 content in their IEvaluationContext

I hope to fix them today, so at least they'll work (or remove them).

PW
Comment 2 Paul Webster CLA 2009-11-20 09:37:52 EST
I fixed generate PSFs and removed the reload CSS for M2.

We'll have to fix the UI editor for M3

PW
Comment 3 Dan Rubel CLA 2009-12-04 16:08:15 EST
For M3, could the code examples be moved to a wiki page and the "e4 > Generate e4 Example Project" be changed to "e4 > Examples" and open a web browser on that new examples wiki page?
Comment 4 Dan Rubel CLA 2009-12-04 16:09:53 EST
Moving the e4 examples to a wiki page would allow us to separate concerns and evolve/enhance/add examples independent of milestones.
Comment 5 Paul Webster CLA 2009-12-14 15:06:09 EST
I think that would be do-able.  Right now the command executes org.eclipse.e4.ui.examples.legacy.workbench.GeneratePsfHandler

We could open a URL in org.eclipse.ui.IWorkbench.getBrowserSupport() ... perhaps create a browser view (although we might get that for free).

I think there's also a bug that would allow us to import a team project set (PSF) from a URL, so we could reference those on the wiki (or some other way) and import them without creating them in the workspace itself.

PW
Comment 6 Dan Rubel CLA 2009-12-16 17:23:47 EST
Created attachment 154606 [details]
Patch with new command that opens web page

Something like this that opens a web page in an editor?
Comment 7 Paul Webster CLA 2009-12-16 19:29:38 EST
# UI: Running the e4 photo demo, contacts demo, and the CSS examples 
http://wiki.eclipse.org/E4/UI/Running_the_photo_demo
http://wiki.eclipse.org/E4/UI/Running_the_contacts_demo
http://wiki.eclipse.org/E4/CSS

I'd use these URLs and add them as 3 separate commands.  You can use the parameterized command from o.e.ui.browser (I didn't even know this existed :-), id = org.eclipse.ui.browser.openBrowser which takes a couple of paramters.

possibly:

<command
      commandId="org.eclipse.ui.browser.openBrowser"
      id="e4.open.contact"
      label="Running the Contact Demo"
      mnemonic="C"
      style="push">
   <parameter
         name="url"
         value="http://wiki.eclipse.org/E4/UI/Running_the_contacts_demo">
   </parameter>
   <parameter
         name="browserId"
         value="org.eclipse.e4.ui.ContactsBrowser">
   </parameter>
   <parameter
         name="name"
         value="Contacts Browser">
   </parameter>
   <parameter
         name="tooltip"
         value="Running the Contacts Demo">
   </parameter>
</command>
Comment 8 Dan Rubel CLA 2009-12-17 11:10:27 EST
I like your approach for modifying the plugin manifest and will use it, but I recommend a single menu item that opens a single web page. That web page contains references to multiple examples available for e4. 

If we have multiple menu items opening multiple web pages, one for each example, then the examples become tightly coupled to the distribution. If instead, as I am recommending, we have a single menu item that opens a single web page listing many if not all of the available examples, then we can add examples independent of the getting the e4 distribution out the door.
Comment 9 Dan Rubel CLA 2009-12-17 11:14:10 EST
Fixing bug 162608 would also help improve the user's first impression. Perhaps the ability to drag a URL pointing to a *.psf file and dropping it on the package view which opens the "Import Project Set..." dialog to import the project set that was dropped.
Comment 10 Paul Webster CLA 2010-06-21 12:58:21 EDT
*** Bug 298011 has been marked as a duplicate of this bug. ***
Comment 11 Paul Webster CLA 2010-06-21 12:58:35 EDT
*** Bug 299842 has been marked as a duplicate of this bug. ***
Comment 12 Lars Vogel CLA 2010-07-19 11:22:20 EDT
*** Bug 318244 has been marked as a duplicate of this bug. ***
Comment 13 Paul Webster CLA 2010-07-19 21:04:57 EDT
Created attachment 174694 [details]
Add new menu items to open web page v02

Apply the web page idea with the already provided command.

I've added the 3 pages that we have, contacts, e4 photo, and css examples.

PW
Comment 14 Paul Webster CLA 2010-07-20 14:28:09 EDT
We're not adding the e4 menu to the 4.0 SDK and we are using our wikis as our main method of providing "getting started' and links to tutorials, so for 4.0 the consensus was to remove this.

PW
Comment 15 Paul Webster CLA 2010-07-20 14:30:58 EDT
Created attachment 174776 [details]
remove e4 menu v01
Comment 16 Paul Webster CLA 2010-07-20 14:31:23 EDT
Boris, removal safe?

PW
Comment 17 Boris Bokowski CLA 2010-07-20 16:00:30 EDT
(In reply to comment #16)
> Boris, removal safe?

yes.
Comment 18 Paul Webster CLA 2010-07-20 16:59:40 EDT
Released
PW