Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 295104 - show id and comment number for attachments
Summary: show id and comment number for attachments
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.5   Edit
Assignee: Frank Becker CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 321177
Blocks:
  Show dependency tree
 
Reported: 2009-11-13 13:53 EST by Andrew Gvozdev CLA
Modified: 2011-01-13 23:31 EST (History)
2 users (show)

See Also:


Attachments
illustration (27.80 KB, image/png)
2009-11-13 14:50 EST, Andrew Gvozdev CLA
no flags Details
commited patch (3.92 KB, patch)
2010-08-10 16:02 EDT, Frank Becker CLA
no flags Details | Diff
mylyn/context/zip (2.71 KB, application/octet-stream)
2010-08-10 16:02 EDT, Frank Becker CLA
no flags Details
commited patch V2 (4.44 KB, patch)
2010-08-11 16:15 EDT, Frank Becker CLA
no flags Details | Diff
mylyn/context/zip (6.08 KB, application/octet-stream)
2010-08-11 16:15 EDT, Frank Becker CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Gvozdev CLA 2009-11-13 13:53:44 EST
Some people refer to attachments by attachment id. The id is not present in Attachments table and one got to scan the comments to figure it out. It would be also neat to keep comment# in the table, there is enough space for that. I think Mylyn can do better than Bugzilla for that one too.
Comment 1 Steffen Pingel CLA 2009-11-13 14:24:22 EST
I'm -1 for putting this into the table since it would clutter the UI with information that is needed infrequently. My sense is that attachments are usually referenced to by bug id which is prominently visible in the task editor. We have also optimized the editor to work on small screen so that it doesn't require more than 600px width by default.

I think that it would be useful to include this information in the tooltip though and maybe provide a Copy Details context menu. Would that satisfy your requirements Andrew?
Comment 2 Andrew Gvozdev CLA 2009-11-13 14:50:07 EST
Created attachment 152198 [details]
illustration

Let me attach a screenshot to illustrate the problem. Which attachment is mentioned in action 13? I had several of those in the past few days, although I admit references like that are infrequent. Tooltip would be some help but some bugs do have a dozen of attachments or so. Maybe there could be some control or preference for expanded table?
Comment 3 Andrew Gvozdev CLA 2009-11-13 14:58:49 EST
What about a small icon against a (folded) comment having an attachment? That would help to spot those.
Comment 4 Steffen Pingel CLA 2009-11-13 16:45:47 EST
I agree that having an affordance to access attachments from the corresponding comment would be very helpful:

bug 199283: [api] make attachments actionable from associated comment in task editor
https://bugs.eclipse.org/bugs/show_bug.cgi?id=199283

If columns were configurable making an ID column available would make sense to me. I have added a comment to bug 250257. Please consider vothin for that.
Comment 5 Andrew Gvozdev CLA 2009-11-13 16:55:54 EST
(In reply to comment #4)
> If columns were configurable making an ID column available would make sense to
> me. I have added a comment to bug 250257. Please consider vothin for that.
Thanks for considering options. I wanted to vote but it is not possible to vote from Mylyn if no votes present yet :)
Comment 6 Steffen Pingel CLA 2010-07-28 20:44:20 EDT
Frank, would you be interested in looking into implementing the UI for this? Based on a discussion with Mik the best thing that we could come up with is to show a popup menu when the user right clicks on the table header. The menu should show a check item for each table column to show/hide it and a Reset item to restore the defaults. This should be implemented generically in TableViewerSupport so that it can be reused for other tables as well.
Comment 7 Frank Becker CLA 2010-08-09 16:19:48 EDT
(In reply to comment #6)
> Frank, would you be interested in looking into implementing the UI for this?
> Based on a discussion with Mik the best thing that we could come up with is to
> show a popup menu when the user right clicks on the table header. The menu
> should show a check item for each table column to show/hide it and a Reset item
> to restore the defaults. This should be implemented generically in
> TableViewerSupport so that it can be reused for other tables as well.

OK,

I start soon.
Comment 8 Frank Becker CLA 2010-08-10 16:02:09 EDT
Created attachment 176276 [details]
commited patch

patch is in HEAD
Comment 9 Frank Becker CLA 2010-08-10 16:02:12 EDT
Created attachment 176277 [details]
mylyn/context/zip
Comment 10 Frank Becker CLA 2010-08-10 16:03:21 EDT
Please verify with the next weekly build.
Comment 11 Frank Becker CLA 2010-08-11 15:31:31 EDT
The patch is now reverted, so we can close bug# 322405. 

I look for an other implementation.

Sorry
Comment 12 Frank Becker CLA 2010-08-11 16:15:06 EDT
Created attachment 176395 [details]
commited patch V2

Here the correction of the first patch.
Comment 13 Frank Becker CLA 2010-08-11 16:15:10 EDT
Created attachment 176396 [details]
mylyn/context/zip
Comment 14 Frank Becker CLA 2010-08-11 16:17:37 EDT
(In reply to comment #11)
> The patch is now reverted, so we can close bug# 322405.
> 
> I look for an other implementation.
> 
> Sorry

The correction is now in HEAD.