Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 294970 - In strings use the name/label when there is just one element/thing
Summary: In strings use the name/label when there is just one element/thing
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: All All
: P2 trivial (vote)
Target Milestone: 3.6 M6   Edit
Assignee: Deepak Azad CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-12 09:33 EST by Deepak Azad CLA
Modified: 2010-02-11 09:53 EST (History)
2 users (show)

See Also:
daniel_megert: review+

Attachments
fix (26.71 KB, patch)
2010-01-25 06:39 EST, Deepak Azad CLA 		daniel_megert: iplog+
daniel_megert: review+
Details | Diff
reworked patch (13.44 KB, patch)
2010-02-03 07:10 EST, Deepak Azad CLA 		daniel_megert: iplog+
daniel_megert: review+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Deepak Azad CLA 2009-11-12 09:33:50 EST 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.5) Gecko/20091102 Firefox/3.5.5
Build Identifier: I20091110-0800

In strings use the name/label when there is just one element/thing
e.g. "Move method 'foo()' to X" instead of "Move method to X"

See Bug 266094 

Reproducible: Always
Comment 1 Dani Megert CLA 2009-11-16 03:03:04 EST 
The intent is not to fix it all over the place but makes sure that the changes we made recently are following that pattern.
Comment 2 Deepak Azad CLA 2010-01-25 06:39:31 EST 
Created attachment 157094 [details]
fix

Updated 15 strings.

Also, I noticed now that I had made a mistake in patch for bug 266094 in ReorgPolicyFactory.java. The singular strings were something like "Move source folder to ''{1}''" (there was no {0}), and I was not passing any parameters for even {1}. Fixed these problems in this patch.
Comment 3 Dani Megert CLA 2010-02-02 10:48:13 EST 
>Also, I noticed now that I had made a mistake in patch for bug 266094
Good catch!

For the changes in ui refactoring/org/eclipse/jdt/internal/ui/refactoring I don't like that you removed and count/length variables and instead use 'lenght' twice. Please leave those as is (but use the new local variable that holds the elements).

Committed the other changes of the patch to HEAD with two little changes:
NewSourceFolderWizardPage
 - instead of using toArray() I used iterator().next()
 - remove makeRelative().toString() as this is not needed
Comment 4 Deepak Azad CLA 2010-02-03 07:10:46 EST 
Created attachment 158045 [details]
reworked patch
Comment 5 Dani Megert CLA 2010-02-03 08:56:39 EST 
Committed reworked patch to HEAD.
Available in builds > N20100202-2000.