Community
Participate
Working Groups
Created attachment 151943 [details] SimpleConfiguratorManipulatorImpl.algorithm() As a result of our PDE build we have a config.ini that has org.eclipse.equinox.ds in its osgi.bundles property: osgi.bundles=reference\:file\:org.eclipse.equinox.ds_1.1.0.v20090601.jar@1\:start,reference\:file\:org.eclipse.equinox.simpleconfigurator_1.0.100.v20090520-1905.jar@1\:start. Is this ok? Shouldn't equinox.ds be in the bundles info instead of in config.ini - like in the standart eclipse installtion. Probable reason: As seen in ProductGenerator.getDefaultStartInfo() PDE build generates a p2.inf file that specifies: ... units.175.id=toolingorg.eclipse.equinox.ds units.175.instructions.configure=setStartLevel(startLevel:1);markStarted(started:true); ... units.172.id=toolingorg.eclipse.equinox.simpleconfigurator units.172.instructions.configure=setStartLevel(startLevel:1);markStarted(started:true); ... And according to SimpleConfiguratorManipulatorImpl.algorithm() (attached) if a bundle has a start level <= of the start level of the simple configurator, it goes to the config.ini
That's fine. I personally would tend to use SL 2 for DS so bundle.info would be used exclusively but SL 1 should also be safe. I believe the DS bundle should "also" be bundles.info. Could you confirm.
Yes, DS bundle should also be in the bundles.info, that was what I meant
Dimo, can you confirm whether ds appears in the bundles.info? I can see cases where the bundle appears only in bundles.info, or the bundle appears in both config.ini and bundles.info. But I can't see the case where the bundle only appears in config.ini
I saw it in the config.ini, so I assumed it appears only there, but now I checked the bundles.info - and it is there also. So it appears in both config.ini and bundles.info
Ok. Good. Thanks Dimo.
If it is ok that bundles with start level the same as simpleconfigurator appear in both config.ini and bundles.info, then the only problem here is that it is indeterminant which case you actually end up with (bundles.info only, or both).
Created attachment 152015 [details] sample pde build for reproducing of the issue I'm not sure whether it is ok to have same bundle on both places. What I meant is the DS bundle should appear only in bundles.info. Right? But currently in our case it appears in both config.ini and bundles.info. I attached a sample that this issue can be reproduced with. There you can see all the input and output...
as the issue is still open (currently: ds bundle appears in both config.ini and bundles.info, expected: appear only in bundles.info), I'm reopening the bug
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie.
This bug was marked as stalebug a while ago. Marking as wontfix. If this report is still relevant for the current release, please reopen and remove the stalebug whiteboard tag.
