Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 294553 - toggleBreakpointsTargetFactories extension point does not respect ActionSet
Summary: toggleBreakpointsTargetFactories extension point does not respect ActionSet
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 4.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.6 M4   Edit
Assignee: Pawel Piech CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-08 10:55 EST by Marc Khouzam CLA
Modified: 2010-01-29 09:24 EST (History)
1 user (show)

See Also:


Attachments
Add workbench IEvaluationContext as a parent (1.79 KB, patch)
2009-11-08 10:55 EST, Marc Khouzam CLA
pawel.1.piech: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Khouzam CLA 2009-11-08 10:55:17 EST
Created attachment 151644 [details]
Add workbench IEvaluationContext as a parent

I've created a new extension of
org.eclipse.debug.ui.toggleBreakpointsTargetFactories and made its enablement
based on an ActionSet. 
      <enablement>
         <with variable="activeContexts">
            <iterate operator="or">
               <equals value="org.eclipse.cdt.debug.ui.tracepointActionSet">
               </equals>
            </iterate>
         </with>
      </enablement>

This condition is not respected because the 'activeContext' variable is not
available in the IEvaluationContext that is used to by the
ToggleBreakpointsTargetManager.

The attached patch adds the IEvaluationContext of the workbench as a parent.
Comment 1 Darin Wright CLA 2009-11-09 09:09:53 EST
Assigning to Pawel for review.
Comment 2 Pawel Piech CLA 2009-11-09 18:29:51 EST
Makes perfect sense, thanks Mark.  I committed the fix.
Comment 3 Pawel Piech CLA 2009-11-09 18:31:01 EST
Marking verified.
Comment 4 Marc Khouzam CLA 2009-11-09 22:39:21 EST
Thanks for the quick commit!