Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 294552 - Remove unused externalized strings from org.eclipse.jdt.ui etc.
Summary: Remove unused externalized strings from org.eclipse.jdt.ui etc.
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: All All
: P3 trivial (vote)
Target Milestone: 3.6 M4   Edit
Assignee: Deepak Azad CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-08 08:44 EST by Deepak Azad CLA
Modified: 2009-12-08 04:01 EST (History)
3 users (show)

See Also:

Attachments
fix (236.07 KB, patch)
2009-11-13 02:04 EST, Deepak Azad CLA 		daniel_megert: iplog+
daniel_megert: review+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Deepak Azad CLA 2009-11-08 08:44:14 EST 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.5) Gecko/20091102 Firefox/3.5.5
Build Identifier:  I20091030-1201

Remove unused externalized strings from org.eclipse.jdt.ui etc. 

Reproducible: Always

Steps to Reproduce:
When I run 'Find broken externalized strings' utility on my workspace it shows 931 problems. A number of these strings are Eclipse NLS style i.e. there is a Java constant and that constant is not used. These strings can be removed
Comment 1 Deepak Azad CLA 2009-11-13 02:04:40 EST 
Created attachment 152131 [details]
fix

I have removed the unused strings (the ones externalized in eclipse way)

Summary of changes
-931 problems in org.eclipse.jdt.ui. 75 are left. There were 32 in FoldingMessages.properties, these are used to construct strings. For the rest I have filed Bug 295040.
-10 problems in org.eclipse.ltk.core.refactoring. All removed
-14 problems in org.eclipse.ltk.ui.refactoring. All removed
-18 problems in org.eclipse.jdt.junit. All removed
Comment 2 Dani Megert CLA 2009-11-17 02:58:14 EST 
Thanks for the patch Deepak!

Fixed in HEAD.
Available in builds >= I20091117-0800.
Comment 3 Deepak Azad CLA 2009-11-17 23:48:08 EST 
Dani,the copyright notice for the following file still says 2008 even though it was updated a couple of days back.
/org.eclipse.jdt.junit/src/org/eclipse/jdt/internal/junit/wizards/WizardMessages.properties
(The patch attached here contains this change)
Comment 4 Dani Megert CLA 2009-11-18 03:09:21 EST 
(In reply to comment #3)
> Dani,the copyright notice for the following file still says 2008 even though it
> was updated a couple of days back.
> /org.eclipse.jdt.junit/src/org/eclipse/jdt/internal/junit/wizards/WizardMessages.properties
> (The patch attached here contains this change)
Fixed.
Comment 5 Raksha Vasisht CLA 2009-12-08 04:01:33 EST 
Verified for 3.6 M4 with I20091207-1800.