Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 294418 - Configtest.runBare() converts exception failures to exception errors
Summary: Configtest.runBare() converts exception failures to exception errors
Status: CLOSED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: cdo.core (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Eike Stepper CLA
QA Contact: Eike Stepper CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-06 00:52 EST by Caspar D. CLA
Modified: 2010-06-29 09:23 EDT (History)
2 users (show)

See Also:
stepper: review+


Attachments
Patch (1.02 KB, patch)
2009-11-06 04:42 EST, Caspar D. CLA
stepper: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Caspar D. CLA 2009-11-06 00:52:20 EST
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.14) Gecko/2009090216 Firefox/3.0.1
Build Identifier: CDO HEAD at time of bug submission

*** Copied from EMF newsgroup ***

=================================
Caspar wrote:

In the current HEAD codebase, ConfigTest.runBare() wraps all Throwables in a ConfigTestException. This means that AssertionFailures get wrapped too, and therefore can no longer be identified as such by junit.framework.TestResult.runProtected. As a result, in the JUnit output the test failures show up as errors.

AFAIK, in 2.0 there was no override of runBare() that wrapped the AssertionFailures. What was the reason for this change?

=================================
Eike wrote:

Hi Jasper,

If there was a reason I can not remember it. Can you attach a patch to a
bugzilla that fixes this?

Cheers
/Eike

Reproducible: Always
Comment 1 Caspar D. CLA 2009-11-06 04:42:20 EST
Created attachment 151535 [details]
Patch
Comment 2 Eike Stepper CLA 2009-11-06 13:08:39 EST
Committed to HEAD
Comment 3 Eike Stepper CLA 2009-11-06 13:09:42 EST
Comment on attachment 151535 [details]
Patch

Please confirm that:

1) The number of lines that you changed is smaller than 250.
2) You are the only author of these changed lines.
3) You apply the EPL to these changed lines.
Comment 4 Caspar D. CLA 2009-11-12 06:08:39 EST
(In reply to comment #3)
> (From update of attachment 151535 [details])
> Please confirm that:
> 
> 1) The number of lines that you changed is smaller than 250.
> 2) You are the only author of these changed lines.
> 3) You apply the EPL to these changed lines.

I confirm.
Comment 5 Eike Stepper CLA 2010-06-29 04:36:44 EDT
Available in 3.0 GA:
http://download.eclipse.org/modeling/emf/cdo/updates/3.0-releases/