Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 294090 - NPE could be thrown in RestoreRelatedLinksAction#isEnabled
Summary: NPE could be thrown in RestoreRelatedLinksAction#isEnabled
Status: RESOLVED FIXED
Alias: None
Product: Ecoretools
Classification: Modeling
Component: General (show other bugs)
Version: 0.9.0   Edit
Hardware: All All
: P3 critical
Target Milestone: M5   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-03 12:09 EST by Mariot Chauvin CLA
Modified: 2011-05-20 05:32 EDT (History)
3 users (show)

See Also:

Attachments
patch for head (1.59 KB, patch)
2009-11-03 12:12 EST, Mariot Chauvin CLA 		mariot.chauvin: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mariot Chauvin CLA 2009-11-03 12:09:18 EST 
Current RestoreRelatedLinksAction#isEnabled code do this :

"EPackageEditPart.MODEL_ID.equals(getCurrentDiagram().getType()"

However RestoreRelatedLinksAction#iGetCurrentDiagram returns null if editorPart is not an instance of DiagramEditor.
Comment 1 Mariot Chauvin CLA 2009-11-03 12:12:37 EST 
Created attachment 151221 [details]
patch for head
Comment 2 Mariot Chauvin CLA 2009-12-15 08:33:45 EST 
I just set the severity to critical, as we are blocked in UI testing due to this bug :/.
David could you have a look ?
Patch is really small !
Thanks,

Mariot
Comment 3 Jacques LESCOT CLA 2010-01-20 11:57:23 EST 
Mariot,

Sorry for the delay. I have finally integrated your patch.
Comment 4 Mariot Chauvin CLA 2010-01-20 11:59:15 EST 
(In reply to comment #3)
> Mariot,
> 
> Sorry for the delay. I have finally integrated your patch.

Thanks !