Comment 1 Alan Humphrey 2009-11-01 20:25:49 EST

Created attachment 151035 [details]
Zipfile containing source code and plugin.xml for makefile and autoopts support.

Greg,

Attached to this bug is a zipfile containing the source code and plugin.xml related to the makefile and autoopts support added to the ISP Plugin.

All strings have been externalized. There are ~22 lines addedd to plugin.xml and ~50 added to AnalyzePopUpAction.java. Many other files had to be slightly altered, and the changes will be predominately diffs. Lots of these edits were due to more strings I found that needed to be externalized or marked to ignore (I really like Eclipse's externalization tool), in addition to the few strings that were added. No new classes were added.

There were far fewer files unchanged than changed so I just zipped up the plugin project, excluding the unaltered files. Plugin.xml is at the top level. I think there might a fair number of lines added in the Messages package as well.

Please let me know if I've done things correctly and also if there's any problems. All the code formatting was done with the built-in Eclipse settings.

Thanks.
-Alan

Comment 2 Greg Watson 2009-11-02 08:05:59 EST

Hi Alan, please have each author confirm the following:

1.  They authored 100% of the content
2.  They have the rights to donate the content to Eclipse
3.  They are donating the contribution under the Eclipse Public License

Thanks,
Greg

Comment 3 Greg Watson 2009-11-02 08:11:59 EST

Rather than using a zip file, it would be better to create a patch directly from your workspace and attach that to the bug (select the plugins, right click in the project explorer and select Team>Create Patch...) I can then apply the patch directly to my workspace to check that everything is ok. The patch will add/remove files if necessary.

Thanks,
Greg

Comment 4 Alan Humphrey 2009-11-02 11:00:55 EST

Greg,

Per your earlier request:

1. I Alan Humphrey and Chris Derrick authored 100% of the content.
2. I Alan Humphrey have the rights to donate the content to Eclipse.
3. I Alan Humphrey am donating the contribution under the Eclipse Public License.

Alan Humphrey


(In reply to comment #2)
> Hi Alan, please have each author confirm the following:
> 
> 1.  They authored 100% of the content
> 2.  They have the rights to donate the content to Eclipse
> 3.  They are donating the contribution under the Eclipse Public License
> 
> Thanks,
> Greg

Comment 5 Alan Humphrey 2009-11-02 11:03:48 EST

Greg,

Understood. Our apologies for the inconvenience here. We were unaware of the Team>Create Patch tool.

Any further modifications will use this mechanism and should be very minor.

Thanks again.
Alan



(In reply to comment #3)
> Rather than using a zip file, it would be better to create a patch directly
> from your workspace and attach that to the bug (select the plugins, right click
> in the project explorer and select Team>Create Patch...) I can then apply the
> patch directly to my workspace to check that everything is ok. The patch will
> add/remove files if necessary.
> 
> Thanks,
> Greg

Comment 6 Greg Watson 2009-11-02 11:24:30 EST

If you could replace the zip attached to this (and the other) bug with a patch it would be appreciated.

Comment 7 Chris 2009-11-02 12:30:28 EST

I Chris Derrick and Alan Humphrey authored 100% of the content.
I Chris Derrick have the rights to donate the content to Eclipse.
I Chris Derrick am donating the contribution under the Eclipse Public License.

Comment 8 Alan Humphrey 2009-11-02 13:41:02 EST

Created attachment 151103 [details]
ISP Plugin Patch

Hi Greg,

Attached is the patch for the ISP plugin you requested, generated by the team->create patch tool.

-Alan

Comment 9 Greg Watson 2009-11-02 16:03:08 EST

This has now been committed.