Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 293744 - [Webapp]Allow additional section to be added to the bar upside
Summary: [Webapp]Allow additional section to be added to the bar upside
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6 M3   Edit
Assignee: Hao Zhang CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-29 22:32 EDT by Hao Zhang CLA
Modified: 2009-11-17 19:40 EST (History)
2 users (show)

See Also:

Attachments
Patch V1 (16.17 KB, patch)
2009-11-17 02:14 EST, Hao Zhang CLA 		cgold: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hao Zhang CLA 2009-10-29 22:32:55 EDT 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; zh-CN; rv:1.9.1.3) Gecko/20090824 Firefox/3.5.3
Build Identifier: 

Now, the upper bar of the inforcenter only contains one section for searching.
Right side of this bar is empty.
One extension point will be added, which will allow additional section to be added to the bar upside.

Reproducible: Always
Comment 1 Chris Goldthorpe CLA 2009-10-30 19:19:51 EDT 
Would this be in the form of an extra frame?
Comment 2 Hao Zhang CLA 2009-10-30 22:12:41 EDT 
(In reply to comment #1)
> Would this be in the form of an extra frame?

Yes, I think it's better to place it in an extra frame.
Comment 3 Chris Goldthorpe CLA 2009-10-30 23:35:57 EDT 
In that case we could use the extra frame extension point. AbstractFrame has a getLocation() method which can currently only take one value, BELOW_CONTENT. We could allow it to return a different value to indicate this new location.
Comment 4 Hao Zhang CLA 2009-11-03 03:23:10 EST 
I see, that's a good idea to reuse the extra frame extension point.
And I also think in basic UI, it's useless to allow additional section in upside bar. So, shall we just support this function in advanced UI?
Comment 5 Chris Goldthorpe CLA 2009-11-03 12:38:49 EST 
Just supporting it in advanced UI is fine.
Comment 6 Hao Zhang CLA 2009-11-17 02:14:38 EST 
Created attachment 152370 [details]
Patch V1

I reuse the extra frame extension point to realize this function.

A new frameset called 'HelpToolbarFrame' is added, which include 'SearchFrame' by default, and the additional section will also be included in 'HelpToolbarFrame'.

Considering of the layout and size of helptoolbar frame, only one additional frame is allowed to add to helptoolbar frame.

And one limitation of this patch is that, when content is too long in one frame, it will be truncated.
Comment 7 Chris Goldthorpe CLA 2009-11-17 19:40:48 EST 
Patch is good in every respect. Committed to HEAD.